Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The link modal posts list suggestion is not accessible #2083

Closed
afercia opened this issue Jul 29, 2017 · 0 comments · Fixed by #2098
Closed

The link modal posts list suggestion is not accessible #2083

afercia opened this issue Jul 29, 2017 · 0 comments · Fixed by #2098
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jul 29, 2017 •
edited
Loading

The link modal posts search / suggestions merged via #1985

screen shot 2017-07-24 at 13 58 25

should be implemented as an ARIA combobox widget + listbox as done for the Tags suggestion. This was originally noted in the related issue #1040 but the implementation missed to address any accessibility feature.

The PR mentions this:

This needs some Accessibility eyes, We can navigate using arrows but I guess this is far from perfect.

So I'm opening a specific issue. The UI should basically replicate what was already done for the Tag suggestions, see #1141. I hope the great work done there can be re-used easily. Worth also considering some abstraction.

Worth noting the current implementation is actually an a11y regression compared to the current functionality in WordPress.
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 29, 2017
@youknowriad youknowriad mentioned this issue Jul 31, 2017
Merged
ceyhun pushed a commit that referenced this issue Apr 22, 2020
@SergioEstevao
Merge pull request #2083 from wordpress-mobile/issue/fix_pre_style
4783f25 
Fix pre block style to use monospace font.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accessibility: Fix the accessibility of the url input using a combobox WordPress/gutenberg
1 participant
@afercia