Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The classic block doesn't work on the Site Editor Page #23086

Closed
youknowriad opened this issue Jun 11, 2020 · 11 comments · Fixed by #44554
Closed

The classic block doesn't work on the Site Editor Page #23086

youknowriad opened this issue Jun 11, 2020 · 11 comments · Fixed by #44554
Assignees
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Capture d’écran 2020-06-11 à 11 15 30 AM

TinyMCE might not be loaded properly.

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Block] Classic Affects the Classic Editor Block [Feature] Full Site Editing labels Jun 11, 2020
@mtias
Copy link
Member

mtias commented Jun 11, 2020

It might make sense to disable it there for now.

@youknowriad
Copy link
Contributor Author

@mtias Not sure we can, I only noticed this because I had an existing page using it and I tried to load that page in the site editor.

@itsjusteileen
Copy link
Contributor

From a documentation perspective @youknowriad, would we say that the classic block would or would not be expected to work in FSE.

@zaguiini
Copy link
Member

So wouldn't it be better to hide the block instead of displaying it on the list? It's still a problem...

@Mamaduka
Copy link
Member

Mamaduka commented Jan 5, 2022

I'm removing this issue from WP 5.9 project board since RC1 was released last night.

Let's try and land a fix for this in a minor release.

@Addison-Stavlo
Copy link
Contributor

👋 I see this is on the 5.9.x todo list, sounds like we need to revisit and reprioritize?

@annezazu
Copy link
Contributor

annezazu commented Sep 14, 2022

Tested this with 14.1 RC1 and an error occurs. Adding to 6.1 board. I think we should remove this from usage in the Site Editor until there's a fix or a more well thought out solution cc @michalczaplinski @ockham as a heads up.

@ockham ockham moved this from Triage to Todo in WordPress 6.1 Editor Tasks Sep 14, 2022
@talldan
Copy link
Contributor

talldan commented Sep 19, 2022

A possible option might be making a new 'freeform' block. I would envisage it having a preview of the contents and a 'Convert to blocks' button that's visible when selected. The trade off would be that the block probably wouldn't be editable, but it would at least be better than an error.

For some history, the widget editors tried using the html block as the freeform block instead of the classic block, but there were a couple of issues. The first being that the block delimiter isn't rendered for a freeform block, so plugins are unable to extend the html block attributes in the widget editors. The second issue is that autop runs on freeform content, so any html blocks get unwanted <p> tags. There was a fix for this in the widget editors - #42623, but it may be better to use a separate new block.

@ockham
Copy link
Contributor

ockham commented Sep 28, 2022

Assigning to @michalczaplinski -- Michal will look into disabling the block in the Site Editor 🙂

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 29, 2022
@michalczaplinski
Copy link
Contributor

michalczaplinski commented Sep 29, 2022

I've opened #44554 to hide the block when in the Site Editor but I ran out of time to fix it completely today (more details in the PR).

@michalczaplinski michalczaplinski moved this from Todo to In Progress in WordPress 6.1 Editor Tasks Sep 29, 2022
Repository owner moved this from In Progress to Done in WordPress 6.1 Editor Tasks Sep 30, 2022
@michalczaplinski
Copy link
Contributor

The Classic block is now hidden from the inserter in the Site Editor: #44554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

10 participants