Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic block crashes when loaded into Site Editor as part of a Reusable block or post content #48938

Closed
bobbingwide opened this issue Mar 8, 2023 · 5 comments
Labels
[Block] Block The "Reusable Block" Block [Block] Classic Affects the Classic Editor Block [Type] Bug An existing feature does not function as intended

Comments

@bobbingwide
Copy link
Contributor

Description

While testing WordPress 6.2-beta5, I inserted a Reusable block into my home page in order to see the color purple.
When I opened the Site Editor the Reusable block was loaded into the post content block, but the Classic block within it encountered an error.

Uncaught TypeError: Cannot read properties of undefined (reading 'tinymce')

I've since discovered that the problem also occurs for Classic blocks being displayed in Post Content.

See also #23086

Step-by-step reproduction instructions

For a site which displays a static page as the home page

  1. Edit your home page
  2. insert a Classic block
  3. Save
  4. Choose Edit site
  5. Scroll down to see that the Classic block has encountered an error.

Screenshots, screen recording, code snippet

This screenshot is for the Classic block within the Reusable block

image

This screenshot is for the Classic block directly in post content

image

Environment info

  • WordPress 6.2-beta5
  • Gutenberg 15.2.4

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@annezazu annezazu moved this to 📥 Todo in WordPress 6.2 Editor Tasks Mar 8, 2023
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Classic Affects the Classic Editor Block [Block] Block The "Reusable Block" Block labels Mar 8, 2023
@annezazu annezazu moved this from 📥 Todo to 🗣️ In discussion, needs decision in WordPress 6.2 Editor Tasks Mar 8, 2023
@annezazu
Copy link
Contributor

annezazu commented Mar 8, 2023

Adding this to the 6.2 board proactively and for consideration. It's by design that the site editor doesn't work with the classic block so I'm not quite sure what our options are here. Curious what @youknowriad thinks since you originally opened an issue about the classic block not working in the site editor, leading to it being hidden/removed.

@Mamaduka
Copy link
Member

Mamaduka commented Mar 9, 2023

Here's a recent attempt to fix Classic block failure in the Site Editor - #48129.

@bobbingwide
Copy link
Contributor Author

Today I re-tested in a different site without plugins and with/without Gutenberg 15.3.1
In both cases the Classic block was converted to Custom HTML.
I'll rerun the original tests.

image

@bobbingwide
Copy link
Contributor Author

bobbingwide commented Mar 9, 2023

Rerun with/without Gutenberg 15.3.1, the Classic blocks are converted to Custom HTML.

image

@github-project-automation github-project-automation bot moved this from 🗣️ In discussion, needs decision to ✅ Done in WordPress 6.2 Editor Tasks Mar 9, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Mar 9, 2023

Thanks for re-testing, @bobbingwide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Block The "Reusable Block" Block [Block] Classic Affects the Classic Editor Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

3 participants