-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image block "Link to" preference not remembered #23154
Comments
Hi, and thanks for the report! We chatted about this ticket today in triage. Folks present were able to validate that this behavior existed in the Media Library + Classic Editor, but couldn't find the behavior previously in Gutenberg. Because the UX flows are different in Gutenberg than the Media Library + Classic Editor, setting this ticket as an Enhancement, and requesting Design Feedback, to see if folks think the model (of saving this preference) fits the user flows here, and if so, how it should be presented to users. In the meantime, if you'd like to set the preference for yourself, it looks like you should be able to set the option using the method described at the top of this PR: #25578 |
@getsource nice! and thanks for mentioning #25578 :) |
Testing with WordPress 5.7 beta 1. Added an image. Clicked to link it to the media file. Please retest and close the issue if it has been fixed. Thanks. |
Hi @paaljoachim I think you misunderstood the issue. Previously, before the arrival of the new editor, when you inserted an image and set "Link to" either "Media File" or "Attachment page" once, that choice would be remembered for any subsequently inserted image. So the second and following images would automatically be linked to the media file or the attachment page just as you set the first image. This is no longer the case. You have to do the link option each time you insert an image. See your own test: "Added another image. Clicked to link it to the media file." This step used to be not needed as it would automatically have this preset for the second image... Hope I explained that more clearly this time, and did not make it even more confusing ;) |
@paaljoachim I've nothing to add, I was in the triage meeting where this was discussed, and @getsource has already summarised that excellently. As the label and previous comment mentions this 'Needs Design Feedback' to determine if it's a desired feature (I'm not a designer). |
Associated issue which contains a lot of comments: |
Repeating monotonous stubborn tasks in a software is often an indication that something is wrong UX wise. |
Describe the bug
Before Gutenberg, and maybe even during the first stages of Gutenberg, when inserting an image the option "Link to" was pre-selected with the previous used selection. So if you had once chosen "Link to: Media File", a newly inserted image would by default also be linked to the media file.
This seems to be no longer the case. Inserting an image block, one has to always set the link manually to either a custom URL, media file or attachment page.
This feels like a regression...
To reproduce
Steps to reproduce the behavior:
Expected behavior
I expected the second inserted image to behave as the first inserted image and be linked to its full size media file.
Editor version (please complete the following information):
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: