Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block "Link to" preference not remembered #23154

Open
RavanH opened this issue Jun 15, 2020 · 8 comments
Open

Image block "Link to" preference not remembered #23154

RavanH opened this issue Jun 15, 2020 · 8 comments
Labels
[Block] Image Affects the Image Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@RavanH
Copy link

RavanH commented Jun 15, 2020

Describe the bug
Before Gutenberg, and maybe even during the first stages of Gutenberg, when inserting an image the option "Link to" was pre-selected with the previous used selection. So if you had once chosen "Link to: Media File", a newly inserted image would by default also be linked to the media file.

This seems to be no longer the case. Inserting an image block, one has to always set the link manually to either a custom URL, media file or attachment page.

This feels like a regression...

To reproduce
Steps to reproduce the behavior:

  1. Go to edit a post
  2. Insert an image block, choose the link "Media File"
  3. Save the post
  4. Insert another image block
  5. Save post and check the post front-end. First image will be linked, the second not.

Expected behavior
I expected the second inserted image to behave as the first inserted image and be linked to its full size media file.

Editor version (please complete the following information):

  • WordPress version: 5.4.2
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? Default

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Chrome
  • Version: 83.0.4103.97
@annezazu annezazu added [Block] Image Affects the Image Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Testing Needs further testing to be confirmed. labels Jun 22, 2020
@getsource
Copy link
Member

Hi, and thanks for the report!

We chatted about this ticket today in triage.

Folks present were able to validate that this behavior existed in the Media Library + Classic Editor, but couldn't find the behavior previously in Gutenberg.

Because the UX flows are different in Gutenberg than the Media Library + Classic Editor, setting this ticket as an Enhancement, and requesting Design Feedback, to see if folks think the model (of saving this preference) fits the user flows here, and if so, how it should be presented to users.

In the meantime, if you'd like to set the preference for yourself, it looks like you should be able to set the option using the method described at the top of this PR: #25578

@getsource getsource added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. and removed Needs Testing Needs further testing to be confirmed. labels Nov 24, 2020
@RavanH
Copy link
Author

RavanH commented Nov 25, 2020

@getsource nice! and thanks for mentioning #25578 :)

@paaljoachim
Copy link
Contributor

Testing with WordPress 5.7 beta 1.
Theme Twenty Twenty One.
Gutenberg plugin not activated.
Chrome
Local site
OSX 10.15.7

Added an image. Clicked to link it to the media file.
Added another image. Clicked to link it to the media file.
Checked the frontend. Both images were linked to the media file.

Please retest and close the issue if it has been fixed. Thanks.

@RavanH
Copy link
Author

RavanH commented Feb 10, 2021

Hi @paaljoachim I think you misunderstood the issue. Previously, before the arrival of the new editor, when you inserted an image and set "Link to" either "Media File" or "Attachment page" once, that choice would be remembered for any subsequently inserted image. So the second and following images would automatically be linked to the media file or the attachment page just as you set the first image.

This is no longer the case. You have to do the link option each time you insert an image. See your own test: "Added another image. Clicked to link it to the media file." This step used to be not needed as it would automatically have this preset for the second image...

Hope I explained that more clearly this time, and did not make it even more confusing ;)

@paaljoachim
Copy link
Contributor

Hi @RavanH Rolf

Ahh yes. Before Gutenberg in the Classic Editor it would remember the last link choice that was done.
Thank you for clearing that up! Not sure what else to say at present time.

@talldan Dan might have something to add.

@talldan
Copy link
Contributor

talldan commented Feb 11, 2021

@paaljoachim I've nothing to add, I was in the triage meeting where this was discussed, and @getsource has already summarised that excellently.

As the label and previous comment mentions this 'Needs Design Feedback' to determine if it's a desired feature (I'm not a designer).

@paaljoachim
Copy link
Contributor

Associated issue which contains a lot of comments:
#8663

@porg
Copy link

porg commented Jul 28, 2023

Repeating monotonous stubborn tasks in a software is often an indication that something is wrong UX wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants