Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons Block: Add full-width button style #24705

Closed
iamtakashi opened this issue Aug 21, 2020 · 4 comments
Closed

Buttons Block: Add full-width button style #24705

iamtakashi opened this issue Aug 21, 2020 · 4 comments
Labels
[Block] Buttons Affects the Buttons Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi

Comments

@iamtakashi
Copy link

It'd be nice to allow a button to be full-width of a parent.

For example, full-width buttons are pretty common in a pattern like a pricing table.

Frame 20

Full-width buttons can be seen in forms too, and it could be useful to add a block style for it.

@alaczek
Copy link

alaczek commented Aug 24, 2020

Yes, I agree. I'm wondering though if it wouldn't be more useful to be able to set the width of the button, which would cover full-width buttons too. This is the design I had in mind:

image

@mtias
Copy link
Member

mtias commented Aug 26, 2020

cc @apeatling for thoughts. It seems like some predefined percentages could be useful as well — 50%, 25% etc. Or it could be a count of how many buttons per row.

@mtias mtias added the [Block] Buttons Affects the Buttons Block label Aug 26, 2020
@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Sep 25, 2020
@apeatling
Copy link
Contributor

apeatling commented Oct 8, 2020

I like the idea of setting percentages, and using flexbox so the columns sort themselves out based on width.

@iamtakashi
Copy link
Author

The awesome work from @stacimc made this reality, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi
Projects
None yet
Development

No branches or pull requests

4 participants