Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: "Link in Bio" Theme #2363

Closed
wants to merge 19 commits into from
Closed

Try: "Link in Bio" Theme #2363

wants to merge 19 commits into from

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Aug 17, 2020

A simple Seedlet variant that comes with a one-pager headstart content akin to a typical linktr.ee site.

Desktop Mobile
dotorgthemes test_ dotorgthemes test_ (1)

It comes with a "Large Buttons" block style for the Social Links block, to achieve that list of social links at the top. It's missing editor styles for this right now.

This still needs a bunch of refinement and testing. 😉

Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Very cool to see how Seedlet can be quickly adapted for this kind of use case.

Is it possible to test the headstart annotations if the theme isn't activated for testing yet on wpcom?

@kjellr
Copy link
Contributor Author

kjellr commented Aug 17, 2020

Is it possible to test the headstart annotations if the theme isn't activated for testing yet on wpcom?

Hmm — I'm not actually sure. 😄 @jeffikus or @allancole do you know?

@ianstewart
Copy link
Contributor

ianstewart commented Aug 17, 2020

Is it possible to test the headstart annotations if the theme isn't activated for testing yet on wpcom?

I think if it's in /pub on wpcom we can run headstart commands on it from the command-line. It shouldn't need to be network-activated.

@kjellr
Copy link
Contributor Author

kjellr commented Aug 18, 2020

Ah ok, thanks. I can deploy this if we want, but I'm a little hesitant to deploy it until we know we want it? I'm not sure. 😄

Anyway, I'm going to share some additional notes + comps for this theme later this week, so we can decide then.

@jeffikus
Copy link
Contributor

Yes, you can test them. We did it with the Varia based themes. @ianstewart is correct, as long as you can see it in terminal in the pub or premium folders it will work.

@kjellr
Copy link
Contributor Author

kjellr commented Aug 18, 2020

Just noting a few things I know are missing here:

  • Editor styles for the custom link block style
  • Custom color support (It’ll need new annotations 🙃)
  • IE11 styles (it looks like these aren't generated automatically).

@ianstewart
Copy link
Contributor

I'm a little hesitant to deploy it until we know we want it?

How much of the theme could be turned into a Pattern?

@kjellr
Copy link
Contributor Author

kjellr commented Aug 19, 2020

How much of the theme could be turned into a Pattern?

Currently, the main thing here that makes this theme unique is the block style for the social links block:

Screen Shot 2020-08-19 at 8 09 57 AM

Without that being defined (whether in a theme or in a plugin that's loaded), the pattern would be pretty boring:

Screen Shot 2020-08-19 at 8 14 06 AM

The big/full-width buttons are what makes this seem like a linktr.ee sort of thing.

@ianstewart
Copy link
Contributor

Without that being defined (whether in a theme or in a plugin that's loaded), the pattern would be pretty boring …

Ah, yeah. Is that something that could be shipped up as an enhancement to the block itself? It reminds of me of navigation block issues.

It also makes me wonder if we could just reproduce this without the social links block too, as a pattern?

I think we could potentially do that on Dotcom because we have an icon block available there?

cc @iamtakashi for the pattern idea.

@iamtakashi
Copy link
Contributor

iamtakashi commented Aug 20, 2020

I wonder if adding a full-width button style to the Button block would make sense. With full-width buttons, the pattern could just be a bunch of buttons to start with. (A crude example. Narrower default width like Seedlet would work better)

iamtakashi20160810133540 wordpress com_

It might not be too much of a hard-sell... A full-width button isn't uncommon, especially in a confined space, and it's probably useful not just for this.

@kjellr
Copy link
Contributor Author

kjellr commented Aug 28, 2020

I pushed some updates that change up the color scheme (still a work in progress) and base the patterns off the button block primarily.

I'll tackle more cleanup next week, but for now here are the four patterns it includes:

Default Music Podcast News
dotcomthemes test_ dotcomthemes test_ (1) dotcomthemes test_ (2) dotcomthemes test_ (3)

That last one is clearly pretty broken, so I'll be giving it a little extra attention. I need to make the corner radius of the buttons in the first one match up with the other two too.

I'm also going to take a look at introducing a more interesting default background. Ideally, these backgrounds would be done completely in Gutenberg (and with block-based themes they will!), however for now folks will need to adjust the background in the Customizer. 😕

@kjellr
Copy link
Contributor Author

kjellr commented Aug 31, 2020

Ok, @jeffikus: I think this is ready for someone else to commandeer for a little bit. I put all of the base scaffolding in place. The theme now includes all four of those patterns above, and basic (a little buggy) custom background support:

Screen Shot 2020-08-31 at 12 41 27 PM

It uses the default "links" pattern by default, and supports three other ones:

Default Music Podcast News
dotcomthemes test_ dotcomthemes test_ (1) dotcomthemes test_ (2) dotcomthemes test_ (3)

Each of these are just standard block patterns. I included a few block styles as well to help:

Buttons Block Social Links Block
Screen Shot 2020-08-31 at 1 05 31 PM Screen Shot 2020-08-31 at 1 06 51 PM

Here is an incomplete list of things that definitely do not work yet:

  • The theme pulls the same stylesheet in for the frontend and the editor. This is fine except the background blur causes issues in the editor. We may need to have two separate stylesheets for that.
  • The custom background does not get pulled into the editor.
  • There are no IE styles generated.
  • Color annotations need to be generated for this theme.
  • And in general, it would be great to use Gutenberg entirely for the image, background, and title. But that may need to wait for FSE.

@kjellr kjellr marked this pull request as ready for review August 31, 2020 17:10
@kjellr
Copy link
Contributor Author

kjellr commented Sep 2, 2020

I've updated to match the latest comps. Changes include:

  • The background + colors are brighter and less dreary.
  • The Music pattern (the theme default) now uses a real, live YouTube video.
  • I re-built the Music pattern so that it appears in two columns on larger screens.
  • The border radius for button patterns has been modified so that they work more nicely for multi-line buttons.
  • The editor no longer loads CSS styles it doesn't use (the page header, footer, etc.)

Screenshots:

Mobile Desktop
dotcomthemes test_-3 dotcomthemes test_-4

@iamtakashi
Copy link
Contributor

I'm noting that we've requested an option for full-width button and/or control the width of buttons in Gutenberg. WordPress/gutenberg#24705

@scruffian scruffian closed this Oct 21, 2020
@scruffian scruffian deleted the branch trunk October 21, 2020 14:34
@pbking pbking reopened this Nov 3, 2020
@pbking pbking changed the base branch from master to trunk November 3, 2020 18:06
@scruffian
Copy link
Member

@kjellr given the state of block based themes at this time, what do you think about making this a purely block based theme?

@kjellr
Copy link
Contributor Author

kjellr commented Nov 5, 2020

given the state of block based themes at this time, what do you think about making this a purely block based theme?

It would be incredibly easy to do that. 😄 Way easier than all the stuff in this PR, frankly.

The main issue is that this wouldn't be available for users to try right away on WP.com. We'd need to hold off until block-based themes are available there. If that's ok with folks then I think it would make sense to make this fully block-based.

@kjellr
Copy link
Contributor Author

kjellr commented Aug 2, 2022

Closing due to inactivity. 🕐

@kjellr kjellr closed this Aug 2, 2022
@scruffian scruffian deleted the try/linkinbio-theme branch August 8, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants