-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: "Link in Bio" Theme #2363
Try: "Link in Bio" Theme #2363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Very cool to see how Seedlet can be quickly adapted for this kind of use case.
Is it possible to test the headstart annotations if the theme isn't activated for testing yet on wpcom?
Hmm — I'm not actually sure. 😄 @jeffikus or @allancole do you know? |
I think if it's in /pub on wpcom we can run headstart commands on it from the command-line. It shouldn't need to be network-activated. |
Ah ok, thanks. I can deploy this if we want, but I'm a little hesitant to deploy it until we know we want it? I'm not sure. 😄 Anyway, I'm going to share some additional notes + comps for this theme later this week, so we can decide then. |
Yes, you can test them. We did it with the Varia based themes. @ianstewart is correct, as long as you can see it in terminal in the pub or premium folders it will work. |
Just noting a few things I know are missing here:
|
How much of the theme could be turned into a Pattern? |
Currently, the main thing here that makes this theme unique is the block style for the social links block: Without that being defined (whether in a theme or in a plugin that's loaded), the pattern would be pretty boring: The big/full-width buttons are what makes this seem like a linktr.ee sort of thing. |
Ah, yeah. Is that something that could be shipped up as an enhancement to the block itself? It reminds of me of navigation block issues. It also makes me wonder if we could just reproduce this without the social links block too, as a pattern? I think we could potentially do that on Dotcom because we have an icon block available there? cc @iamtakashi for the pattern idea. |
I wonder if adding a full-width button style to the Button block would make sense. With full-width buttons, the pattern could just be a bunch of buttons to start with. (A crude example. Narrower default width like Seedlet would work better) It might not be too much of a hard-sell... A full-width button isn't uncommon, especially in a confined space, and it's probably useful not just for this. |
Ok, @jeffikus: I think this is ready for someone else to commandeer for a little bit. I put all of the base scaffolding in place. The theme now includes all four of those patterns above, and basic (a little buggy) custom background support: It uses the default "links" pattern by default, and supports three other ones:
Each of these are just standard block patterns. I included a few block styles as well to help:
Here is an incomplete list of things that definitely do not work yet:
|
I've updated to match the latest comps. Changes include:
Screenshots:
|
I'm noting that we've requested an option for full-width button and/or control the width of buttons in Gutenberg. WordPress/gutenberg#24705 |
@kjellr given the state of block based themes at this time, what do you think about making this a purely block based theme? |
It would be incredibly easy to do that. 😄 Way easier than all the stuff in this PR, frankly. The main issue is that this wouldn't be available for users to try right away on WP.com. We'd need to hold off until block-based themes are available there. If that's ok with folks then I think it would make sense to make this fully block-based. |
Closing due to inactivity. 🕐 |
A simple Seedlet variant that comes with a one-pager headstart content akin to a typical linktr.ee site.
It comes with a "Large Buttons" block style for the Social Links block, to achieve that list of social links at the top. It's missing editor styles for this right now.
This still needs a bunch of refinement and testing. 😉