Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnsavedChangesWarning: Turn into functional component, add JSDoc Typings #24767

Closed
ockham opened this issue Aug 24, 2020 · 1 comment · Fixed by #24783
Closed

UnsavedChangesWarning: Turn into functional component, add JSDoc Typings #24767

ockham opened this issue Aug 24, 2020 · 1 comment · Fixed by #24783
Labels
[Package] Components /packages/components

Comments

@ockham
Copy link
Contributor

ockham commented Aug 24, 2020

Carrying over from #24719 (comment). The UnsavedChangesWarning component should be turned into a functional component, and it'd be great if we could also add JSDoc typings while we're at it.

cc/ @david-szabo97
@ockham ockham added the [Package] Components /packages/components label Aug 24, 2020
@david-szabo97
Copy link
Member

👍 Working on it

@david-szabo97 david-szabo97 mentioned this issue Aug 25, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] Components /packages/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UnsavedChangesWarning: Turn into functional component david-szabo97/gutenberg
2 participants
@ockham @david-szabo97