Unify UnsavedChangesWarning's isDirty check #24719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Aug 24, 2020
| const dirtyEntityRecords = __experimentalGetDirtyEntityRecords(); | ||
| return dirtyEntityRecords.length > 0; | ||
| }, | ||
| } ) )( UnsavedChangesWarning ); |
There was a problem hiding this comment.
Nit: There's an opportunity here to refactor the component as a function component + hooks.
There was a problem hiding this comment.
Yep, David and I have been discussing that! I was recommending doing that in a follow-up PR though.
youknowriad
added
the
[Type] Code Quality
This was referenced Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the discussion in this PR: #24659
We bundle the check into the component. Instead of
isEditedPostDirtywe use__experimentalGetDirtyEntityRecordsto determine if there were any changes in the editor. Since we are using__experimentalGetDirtyEntityRecords, this component will work fine in both Post and Site editor.How has this been tested?
Types of changes
Enhancement
Checklist: