Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] should load multiple block stylesheets in iframe #35394

Closed
github-actions bot opened this issue Oct 6, 2021 · 4 comments · Fixed by #55003
Closed

[Flaky Test] should load multiple block stylesheets in iframe #35394

github-actions bot opened this issue Oct 6, 2021 · 4 comments · Fixed by #55003
Assignees
@Mamaduka
Labels
[Status] In Progress Tracking issues with work in progress [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Oct 6, 2021 •
edited
Loading

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should load multiple block stylesheets in iframe

Test path

specs/editor/plugins/iframed-multiple-block-stylesheets.test.js

Errors

[2021-10-06T11:04:14.897Z] Test passed after 2 failed attempts on add/multiple-block-styles.
[2021-10-07T12:32:02.056Z] Test passed after 1 failed attempt on add/multiple-block-styles.
[2021-10-07T13:52:17.990Z] Test passed after 1 failed attempt on fix/server-side-render-regression.
[2021-10-07T14:01:04.721Z] Test passed after 1 failed attempt on trunk.
[2021-10-07T16:01:37.743Z] Test passed after 1 failed attempt on add/comment-avatar.
[2021-10-07T16:02:28.692Z] Test passed after 1 failed attempt on fix/components-navigator-horizontal-scrollbar.
[2021-10-07T16:02:46.544Z] Test passed after 2 failed attempts on trunk.
[2021-10-07T16:25:14.735Z] Test passed after 1 failed attempt on trunk.
[2021-10-07T17:36:06.868Z] Test passed after 1 failed attempt on try/site-logo-tweaks.
[2021-10-07T18:23:29.574Z] Test passed after 2 failed attempts on add/pattern-block.
[2021-10-07T19:25:24.244Z] Test passed after 1 failed attempt on add/preload-more-requests-on-the-navigation-screen.
[2021-10-07T19:58:59.762Z] Test passed after 1 failed attempt on feature/block-editor-events.
[2021-10-07T20:09:23.347Z] Test passed after 1 failed attempt on try/link-control-split-url-text.
[2021-10-07T21:34:32.082Z] Test passed after 1 failed attempt on add/resizable-box-types.
[2021-10-07T21:41:48.445Z] Test passed after 1 failed attempt on trunk.
[2021-10-07T22:58:13.854Z] Test passed after 1 failed attempt on fix/empty-page-list.
[2021-10-08T01:46:51.182Z] Test passed after 1 failed attempt on fix/flaky-nav-test-again.
[2021-10-08T02:25:02.564Z] Test passed after 1 failed attempt on try/cover-min-height-placeholder-resizer.
[2021-10-08T03:27:47.480Z] Test passed after 1 failed attempt on add/template-details-for-template-part.
[2021-10-08T05:19:04.017Z] Test passed after 1 failed attempt on update/navigation-link-css-classes.
[2021-10-08T05:28:37.966Z] Test passed after 1 failed attempt on remove/toolspanel-hardcoded-classnames.
[2021-10-08T06:00:50.929Z] Test passed after 1 failed attempt on trunk.
[2021-10-08T06:12:51.381Z] Test passed after 1 failed attempt on trunk.
[2021-10-08T06:41:51.896Z] Test passed after 2 failed attempts on trunk.
[2021-10-08T08:25:23.736Z] Test passed after 2 failed attempts on update/font-family-block-supports-use-classes.
[2021-10-08T08:40:38.301Z] Test passed after 1 failed attempt on trunk.
[2021-10-08T08:40:57.326Z] Test passed after 2 failed attempts on try/add-split-axial-gap-block-support.
[2021-10-08T08:41:42.791Z] Test passed after 2 failed attempts on trunk.
[2021-10-08T09:20:01.897Z] Test passed after 1 failed attempt on try/site-logo-tweaks.
[2021-10-08T09:38:42.033Z] Test passed after 1 failed attempt on fix/toggle-group-aria-label.
[2021-10-08T09:52:17.348Z] Test passed after 1 failed attempt on add/comment-avatar.
[2021-10-08T10:32:51.445Z] Test passed after 2 failed attempts on trunk.
[2021-10-08T10:52:36.343Z] Test passed after 1 failed attempt on trunk.
[2021-10-08T11:04:37.157Z] Test passed after 1 failed attempt on trunk.
[2021-10-08T11:18:42.698Z] Test passed after 1 failed attempt on fix/strip-html-removing-leading-spaces.
[2021-10-08T12:00:08.875Z] Test passed after 1 failed attempt on mobile/issue/3055-show-disabled-block-reason.
[2021-10-08T12:13:00.136Z] Test passed after 2 failed attempts on font-appearance-fieldset.
[2021-10-08T12:37:25.262Z] Test passed after 1 failed attempt on rnmobile/fix/embed-block-set-empty-url.
[2021-10-08T13:06:13.672Z] Test passed after 2 failed attempts on update/35410-remove-polyfill.
[2021-10-08T13:40:58.914Z] Test passed after 1 failed attempt on add/support-child-theme-json-merging.
[2021-10-08T13:49:46.734Z] Test passed after 2 failed attempts on fix/strip-html-removing-leading-spaces.
[2021-10-08T15:12:44.067Z] Test passed after 1 failed attempt on rnmobile/fix/android-ube-text-selection.
[2021-10-08T15:40:53.447Z] Test passed after 2 failed attempts on trunk.
[2021-10-08T15:43:35.853Z] Test passed after 1 failed attempt on trunk.
[2021-10-08T17:50:02.379Z] Test passed after 1 failed attempt on add/preload-more-requests-on-the-navigation-screen.
[2021-10-08T17:59:27.453Z] Test passed after 2 failed attempts on try/list-view-window.
[2021-10-08T18:25:07.854Z] Test passed after 1 failed attempt on try/list-view-window.
[2021-10-08T19:59:31.167Z] Test passed after 2 failed attempts on rnmobile/fix/column-grid.
[2021-10-09T07:59:57.939Z] Test passed after 1 failed attempt on mobile/issue/3055-show-disabled-block-reason.
[2021-10-09T09:23:45.867Z] Test passed after 2 failed attempts on trunk.
[2021-10-11T00:03:39.483Z] Test passed after 2 failed attempts on trunk.
[2021-10-11T00:44:42.574Z] Test passed after 1 failed attempt on try/add-ellipsis-button-to-site-editor-list-view.
[2021-10-11T04:00:30.670Z] Test passed after 1 failed attempt on fix/number-control-any-step-and-shift-rounding.
[2021-10-11T04:36:30.537Z] Test passed after 2 failed attempts on update/block-styles-preview-panel.
[2021-10-11T09:10:44.117Z] Test passed after 1 failed attempt on mobile/issue/3055-show-disabled-block-reason.
[2021-10-11T09:51:12.844Z] Test passed after 1 failed attempt on try/remove-segmented-separators.
[2021-10-11T10:13:09.466Z] Test passed after 1 failed attempt on add/drag-and-inserter-motion-effects.
[2021-10-11T10:48:20.530Z] Test passed after 1 failed attempt on rnmobile/feature/block-styles-font-size.
[2021-10-11T11:15:12.178Z] Test passed after 1 failed attempt on add/comment-avatar.
[2021-10-11T13:20:26.479Z] Test passed after 2 failed attempts on chore/components-changelog-color-picker.
[2021-10-11T13:25:12.945Z] Test passed after 2 failed attempts on rnmobile/feature/search-block-colors.
[2021-10-11T13:25:39.888Z] Test passed after 1 failed attempt on update/theme-block-placeholder-styling.
[2021-10-11T13:32:10.720Z] Test passed after 1 failed attempt on rnmobile/try/creating-context-constants-for-gallery-block.
[2021-10-11T13:35:09.007Z] Test passed after 1 failed attempt on mobile/issue/3055-show-disabled-block-reason.
[2021-10-11T13:43:29.634Z] Test passed after 1 failed attempt on trunk.
[2021-10-11T14:11:42.233Z] Test passed after 1 failed attempt on trunk.
[2021-10-11T14:18:52.653Z] Test passed after 1 failed attempt on fix/editor-color-palette-regression.
[2021-10-11T15:18:20.233Z] Test passed after 1 failed attempt on rnmobile/embed-block-paste-url.
[2021-10-11T16:26:36.046Z] Test passed after 1 failed attempt on add-categories-toc-faq.
[2021-10-11T17:15:17.759Z] Test passed after 1 failed attempt on rnmobile/try/creating-context-constants-for-gallery-block.
[2021-10-11T17:22:49.359Z] Test passed after 1 failed attempt on add/preload-more-requests-on-the-navigation-screen.
[2021-10-11T18:17:23.409Z] Test passed after 1 failed attempt on try/navigation-label-placeholder.
[2021-10-11T19:51:33.293Z] Test passed after 1 failed attempt on rnmobile/embed-block-paste-url.
[2021-10-11T20:21:43.018Z] Test passed after 1 failed attempt on try/list-view-window.
[2021-10-11T20:22:55.441Z] Test passed after 1 failed attempt on fix/clear-cache-when-preloading-options-requests.
[2021-10-22T11:17:05.322Z] Test passed after 1 failed attempt on trunk.
[2023-03-07T12:02:23.571Z] Test passed after 2 failed attempts on try/dedicated-block-controls-filter.
[2023-07-07T09:11:37.066Z] Test passed after 2 failed attempts on feat/async-block-loading.
[2023-07-21T12:58:19.657Z] Test passed after 2 failed attempts on feat/async-block-loading.
[2023-09-08T17:56:37.716Z] Test passed after 1 failed attempt on add/sorce-map-path.
[2023-09-13T17:44:30.562Z] Test passed after 1 failed attempt on try/fonts-library-frontend-stage1.
[2023-09-14T16:00:41.503Z] Test passed after 1 failed attempt on try/fonts-library-frontend-stage1.
[2023-09-20T16:04:46.993Z] Test passed after 1 failed attempt on fix/date-time-picker-instance-of-iframe.
[2023-09-22T23:40:40.233Z] Test passed after 1 failed attempt on trunk.
[2023-09-28T09:59:55.822Z] Test passed after 1 failed attempt on update/cover-background-label.
[2023-10-03T04:32:17.556Z] Test passed after 1 failed attempt on trunk. 
  ● iframed multiple block stylesheets › should load multiple block stylesheets in iframe

    TimeoutError: waiting for selector `tr[data-slug="gutenberg-test-iframed-multiple-stylesheets"] .deactivate a` failed: timeout 30000ms exceeded

      at new WaitTask (../../node_modules/puppeteer-core/src/common/DOMWorld.ts:813:28)
      at DOMWorld.waitForSelectorInPage (../../node_modules/puppeteer-core/src/common/DOMWorld.ts:656:22)
      at Object.internalHandler.waitFor (../../node_modules/puppeteer-core/src/common/QueryHandler.ts:78:19)
      at DOMWorld.waitForSelector (../../node_modules/puppeteer-core/src/common/DOMWorld.ts:511:25)
      at Frame.waitForSelector (../../node_modules/puppeteer-core/src/common/FrameManager.ts:1290:47)
      at Page.waitForSelector (../../node_modules/puppeteer-core/src/common/Page.ts:3222:29)
      at waitForSelector (../e2e-test-utils/build/@wordpress/e2e-test-utils/src/activate-plugin.js:29:13)
          at runMicrotasks (<anonymous>)
      at Object.<anonymous> (specs/editor/plugins/iframed-multiple-block-stylesheets.test.js:27:3)
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Oct 6, 2021
@Mamaduka
Copy link
Member

Hi, @aristath

Any ideas why we might be getting so many failures for this test on Github?

I tried to reproduce tests locally but had no luck. This is the command I'm using to run it multiple times:

for i in {1..15}; do npm run test-e2e -- packages/e2e-tests/specs/editor/plugins/iframed-multiple-block-stylesheets.test.js; done

@aristath
Copy link
Member

Any ideas why we might be getting so many failures for this test on Github?

No idea, no... However, when I was writing the test for iframed-multiple-block-stylesheets, I noticed that a test which follows a similar logic is iframed-inline-styles, and we disabled that one on #33503.
Perhaps we should just disable this one as well?

@Mamaduka
Copy link
Member

Sounds good. I can keep an eye on failures and disable tests if it's blocking the development 👍

getdave added a commit that referenced this issue Oct 26, 2021
@getdave
Skip offending test
b1b6cf8 
See #35394 (comment)
@getdave getdave mentioned this issue Oct 26, 2021
Merged
7 tasks
getdave added a commit that referenced this issue Oct 26, 2021
@getdave
Skip offending test (#35961)
0bec393 
See #35394 (comment)
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 28, 2022
@github-actions github-actions bot reopened this Mar 7, 2023
@github-actions github-actions bot mentioned this issue Mar 7, 2023
Closed
@github-actions github-actions bot reopened this Jul 7, 2023
@github-actions github-actions bot mentioned this issue Jul 7, 2023
Draft
This was referenced Sep 8, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue Sep 20, 2023
Merged
github-actions bot referenced this issue Sep 22, 2023
@hellofromtonya
Font Face: Gets name from "fontFamily" setting as fallback (#54615)
4aa0382 
Iff the "name" setting does not exist (as it's not required by the schema or documentation), get the font-family name from the required "fontFamily" setting, i.e. within each `typography.fontFamilies`.
@github-actions github-actions bot mentioned this issue Sep 28, 2023
Merged
github-actions bot referenced this issue Oct 3, 2023
@Mamaduka
Block Editor: Avoid double-wrapping selectors when transforming the s…
4ca991d 
…tyles (#54981)

* Block Editor: Avoid double-wrapping selectors when transforming the styles
* Include space in the check
@Mamaduka Mamaduka mentioned this issue Oct 3, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Status] In Progress Tracking issues with work in progress [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate 'iframed multiple block stylesheets' tests to Playwright WordPress/gutenberg
2 participants
@Mamaduka @aristath