Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight color palette only shows colors from the last source #36886

Open
oandregal opened this issue Nov 25, 2021 · 6 comments
Open

Highlight color palette only shows colors from the last source #36886

oandregal opened this issue Nov 25, 2021 · 6 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Format library /packages/format-library [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

oandregal commented Nov 25, 2021

Related #16014 #36841

Description

The color palette component used to highlight RichText content only shows colors from a single palette (default, theme, or custom). This has some weird side-effects such as when the user has added a custom color only that one will be shown.

Step-by-step reproduction instructions

  • Use TwentyTwentyTwo theme.
  • Go to the post editor and add a paragraph.
  • Select some text.
  • Open the "more block tools" in the block toolbar and select the "Highlight" option.

The color component only shows colors from the theme, when it should show defaults, theme, and user colors.

Captura de ecrã de 2021-11-25 19-36-57

If the user adds a single color to the custom palette (via the global styles sidebar in edit site), only that single color will be shown here.

@oandregal oandregal added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Format library /packages/format-library labels Nov 25, 2021
@noisysocks noisysocks added the [Type] Bug An existing feature does not function as intended label Dec 1, 2021
@Mamaduka
Copy link
Member

Mamaduka commented Jan 5, 2022

I'm removing this issue from WP 5.9 board since we're already in the RC phase.

Let's try and land a fix for this in a minor or major release.

@roborourke
Copy link
Contributor

I ran into this recently too, so still a problem. I'll see if I can work out how to support it.

@webmandesign
Copy link
Contributor

I can confirm this is still an issue.

@webmandesign
Copy link
Contributor

However, the issue with Highlight colors seems quite complex: #47439, #40279, #59649

@DamChtlv
Copy link

As of WP 6.5.3, i can confirm it's still an issue

@zoharma
Copy link

zoharma commented Nov 5, 2024

Still happening on 6.6.2 and Twenty Twenty Four. Does not makes sense that I cannot select from theme colours if I have set up custom colours. Please show all available theme and custom colours even if they are not grouped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Format library /packages/format-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants