Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbars appearing in site logo and image block in Site Editor #38086

Closed
annezazu opened this issue Jan 19, 2022 · 6 comments · Fixed by #38123
Closed

Scrollbars appearing in site logo and image block in Site Editor #38086

annezazu opened this issue Jan 19, 2022 · 6 comments · Fixed by #38123
Assignees
Labels
[Block] Image Affects the Image Block [Block] Site Logo Affects the Site Logo Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When adding in an image to the image or social icon block in the site editor (can't replicate when adding to page), scrollbars are showing up around the edges making it very cumbersome to interact with. I think this is related to this issue: #37573

Step-by-step reproduction instructions

  1. Open site editor.
  2. Add an image block or site logo.
  3. Upload an image.
  4. See scrollbars.

Screenshots, screen recording, code snippet

scroll.bar.image.block.mov
scrollbars.in.site.logo.mov

Environment info

  • WordPress 5.9-RC3-52601
  • TT2 theme
  • Chrome
  • MacOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Block] Image Affects the Image Block [Block] Site Logo Affects the Site Logo Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended labels Jan 19, 2022
@hellofromtonya
Copy link
Contributor

hellofromtonya commented Jan 19, 2022

Hmm, I'm not able to reproduce with a site logo or image block.

Env:

  • WordPress: WordPress 5.9-RC3-52601 and on trunk
  • Browsers: Chrome, Safari, Edge, and Firefox
  • OS: macOS Big Sur
  • Theme: TT2
  • Plugins: none and with Gutenberg v12.4.0
  • Localhost: wp-env, Local, and on my personal live website

@chthonic-ds
Copy link
Contributor

chthonic-ds commented Jan 19, 2022

I'm seeing this consistently with a Site Logo block in a template part in the Site Editor.

image

  • WordPress: 5.9-RC3
  • Browsers tested: Chrome, Firefox
  • OS: Win 10
  • Theme: first noticed with custom theme active, confirmed same with TT2
  • Plugins: none

@walbo
Copy link
Member

walbo commented Jan 19, 2022

Seeing the scrollbars here as well. Only getting the scrollbars when the styles are concatenated.

Env:

  • WordPress 5.9-RC3-52601
  • Browser: Chrome, Safari. (Firefox seems fine)
  • OS: macOS Monterey
  • Theme: TT2
  • Plugins: none
  • Localhost: Local
  • SCRIPT_DEBUG: false
  • CONCATENATE_SCRIPTS: Undefined

@hellofromtonya
Copy link
Contributor

Retested locally and on live website and made sure SCRIPT_DEBUG is false. Still can't reproduce. No scrollbars. Hmm.

@Mamaduka
Copy link
Member

I think I've got the fix for this issue; I will create PR tomorrow morning.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 21, 2022
@piotrbak
Copy link

I'm also not able to reproduce the issue. Applied proposed fix to search for regressions, but everything looks just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Site Logo Affects the Site Logo Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants