Site Editor: Fix resizable box scrollbars in blocks #38123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
|
Size Change: +7 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Oops, I tested in several scenarios trying to make sure it's solid, but apparently not enough times 😞 . Thank you for spotting this! I'll give it a try later. |
|
@kevin940726, it's impossible to catch this bug when the plugin is activated, so no worries 👍 |
|
Just to make sure, pinging some folks who were able to reproduce the issue. Hey @annezazu @chthonic-ds @walbo, can you test that this PR resolves the issue? |
|
PR resolves the issue for me, thank you! Before:
After:
|
|
Can confirm it fixes it for me too! Thanks for getting a PR in place so promptly. |
hellofromtonya
approved these changes
Jan 23, 2022
hellofromtonya
added
Backport to WP 6.7 Beta/RC
noisysocks
removed
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 24, 2022
* Site Editor: Fix resizable box scrollbars in blocks * No need to traget direct children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38086.
It looks like the
.components-resizable-box__containerstyles introduced in #38019 were leaking inside the iframe when the WP core loads concatenated CSS files usingload-styles.php.It causes allResizableBoxon canvas to have scrollbars.RR fixes this issue by increasing the specificity of the new styles and only targeting direct children of
.edit-site-visual-editor.How has this been tested?
Unfortunately, plugin CSS assets aren't loaded via
load-styles.php, so it's hard to test this fix. So instead, test that this doesn't introduce regression to the #38019.Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).