HTML Block: Code shown in site editor browse mode

[talldan]

Description

The default view for the Custom HTML block is the HTML code editor mode.

When HTML blocks show up in the site editor in browse mode, they by default show their code, which isn't reflective of what browse mode is supposed to be—a reflection of the user's front-end.

Step-by-step reproduction instructions

1. Open the site editor
2. Add a custom html block with some basic content
3. Enter browse mode

Expected: The block's code isn't shown, the html preview is.
Actual: The block's code is shown

Screenshots, screen recording, code snippet

Environment info

Gutenberg trunk
Brave / Mac OS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[Mamaduka]

I think the solution proposed by @mtias should fix this issue #41066 (comment).

See also #46834.

[t-hamano]

Another PR: #46836

As noted in this comment, relying on isSelected for preview status might cause problems for keyboard users.

[t-hamano]

My other concern is that this block may not necessarily contain content. Perhaps this is not the intended use, but for example, the following code:

If you preview this block, the block will be almost invisible:

This border is also mentioned in #47818, but if this border were removed, the block would be completely invisible and one would not be able to click on the block directly. Personally, I think it is fine as it is now.

[ndiego]

This border is also mentioned in #47818, but if this border were removed, the block would be completely invisible and one would not be able to click on the block directly. Personally, I think it is fine as it is now.

The border has been removed, so I agree that I think the implementation is ok as is. Not ideal, but not a blocker for 6.2.

[youknowriad]

I think we could solve this by using isPreviewMode setting of the block editor.