HTML Block: Force HTML preview in view mode #66440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
t-hamano
commented
Oct 25, 2024
| @@ -23,7 +23,7 @@ const DEFAULT_STYLES = ` | |||
|
|
|||
| export default function HTMLEditPreview( { content, isSelected } ) { | |||
| const settingStyles = useSelect( | |||
| ( select ) => select( blockEditorStore ).getSettings().styles | |||
| ( select ) => select( blockEditorStore ).getSettings().styles || [] | |||
There was a problem hiding this comment.
I'm a bit unsure about this change, but it may cause styles to temporarily become undefined.
I needed to make this change to prevent the following error:
Uncaught TypeError: Cannot read properties of undefined (reading 'filter') at preview.js:34:19
There was a problem hiding this comment.
You can also do something like (settingStyles ?? [] ).filter( ( style ) => style.css ).
P.S. That useSelect is missing the empty dependency array.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +33 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Oct 25, 2024
Comment on lines
+32
to
+34
| const isPreviewMode = useSelect( ( select ) => { | ||
| return select( blockEditorStore ).getSettings().isPreviewMode; | ||
| }, [] ); |
There was a problem hiding this comment.
The isPreviewMode is also available via the private key in the block edit context. However, considering the block library code is probably the most copied code in the repo, using a selector makes more sense.
Mamaduka
approved these changes
Oct 25, 2024
youknowriad
approved these changes
Oct 25, 2024
|
Thanks for the review! I think I've addressed all of the feedback so I'd like to merge it. |
|
Flaky tests detected in 7bcb7c0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11515638670
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: talldan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47819
What?
This PR forces HTML preview in view mode regardless of what the mode of the HTML block is.
Why?
In view mode we cannot edit blocks, and in addition, view mode should show as much of how the blocks will actually be rendered as possible.
How?
check
getSettings().isPreviewMode.Testing Instructions
Screenshots or screencast
e8134991572e541cbc2c3767612626a6.mp4