-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If Page Title comes before Featured Image it is overlapped #50719
Comments
There seems to be an issue with Post Featured Image and the margins applied. You can reproduce by moving any block above it. A related PR was this one by @aaronrobertshaw . In 2023 the Post Featured Image block even if it has a value(from somewhere), still shows the custom control with no value in it. |
Thanks for the ping on this one 👍 I believe there are a few things going on here that lead to this awkward overlap.
The following video illustrates most of the points above. Screen.Recording.2023-05-19.at.10.40.22.am.mp4There isn't currently official support for negative block margins in our UI, nor complex CSS strings in our custom inputs so I'm not sure if this is something that will be addressed for now. If anything, I'd lean towards closing this issue or classifying it as a theme issue. |
Thanks for the detailed answer @aaronrobertshaw! @naomi060397 I agree with Aaron, that we can close the issue, since you now know what is happening and can find a workaround with 2023 in these specific templates. @ciampo @mirka I couldn't find an issue about supporting negative margins in these components, should we create one? I don't include the complex css value(var, etc..), because I know it's really convoluted and there is probably no way currently to support that. |
There's a feature request issue for negative margins and a WIP PR that might be of interest. |
I don't think that supporting this feature really depends on
Yeah, that would be a completely separate issue. Components like |
Description
In the Site Editor using the Twenty Twenty Three theme, I moved the Post Title before the Featured Image and the design broke.
I also tested this in different group blocks and without any parent group block as well. This also occurs on the front-end.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: