Spacing: Fix reset of spacing sizes control #50455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f3b9ba9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4922327361
|
glendaviesnz
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes regression in reset of spacing sizes control which resulted in incorrect switch to custom input view for the control.
Why?
Restores original behaviour, resetting the behaviour should leave the control in its default state.
How?
Add a check for a defined value when determining if a change in value should result in display of the custom input.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-05-09.at.2.15.02.pm.mp4
Screen.Recording.2023-05-09.at.2.13.27.pm.mp4