Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Gutenberg update problem #51214

Closed
nurseneedles opened this issue Jun 3, 2023 · 4 comments
Closed

New Gutenberg update problem #51214

nurseneedles opened this issue Jun 3, 2023 · 4 comments
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@nurseneedles
Copy link

Description

When making an affiliate link in Gutenberg, you enter the link URL and under that it says "open in a new page", then there used to be options to make the link no-follow. Those have disappeared and that is a big issue for compliance.
image

Step-by-step reproduction instructions

  1. Write text you want to hyperlink.
  2. Highlight text & Click the "add link" icon.
  3. Type in hyperlink.
  4. Click pencil to edit link and then choose open in a new tab.
  5. Under that, the option for "no follow" links for ads is missing.

Screenshots, screen recording, code snippet

image

Environment info

Gutenberg 15.9.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jun 4, 2023

Thank you for opening your first issue 👍

Those have disappeared

I could be wrong but I do not think adding "no-follow" to links was ever part of Gutenberg core. Could it be the case that you had added this feature using a plugin? I know that some plugins, EditorsKit among them, will add this option for you:

Screen Shot on 2023-06-04 at 08:45:44

Also, I was looking around and I see there is already an issue for this #13542

I am going to close this issue in favor of the older one. For future issues, I please consider using a title that's as descriptive as possible of the issue. In this case the ideal title would have been something along the lines of "Regression: No-follow setting in links missing after update".

Thanks again for your contribution!

@mrfoxtalbot mrfoxtalbot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
@mrfoxtalbot mrfoxtalbot added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jun 4, 2023
@nurseneedles
Copy link
Author

nurseneedles commented Jun 6, 2023 via email

@nurseneedles
Copy link
Author

nurseneedles commented Jun 6, 2023 via email

@mrfoxtalbot
Copy link

hi @nurseneedles!

promise you Gutenberg very definitely did have the option to make links no follow.

Sure, I could be wrong! My suggestion is to head over to #13542 and drop a comment there. If the feature was indeed available in the past, the contributors there will be able to confirm it.

I believe my ticket is more relevant.

That ticket has more traction so it will be more likely you will get a reply. I would strongly encourage you to move the conversation there. You can always open a new ticket if needed (please consider a more descriptive title for future tickets, as I suggested in my previous comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants