Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Replace deprecated isSmall property with size="small" property #53560

Closed
t-hamano opened this issue Aug 11, 2023 · 5 comments · Fixed by #59304 or #59302
Closed

Button: Replace deprecated isSmall property with size="small" property #53560

t-hamano opened this issue Aug 11, 2023 · 5 comments · Fixed by #59304 or #59302
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@t-hamano
Copy link
Contributor

Related to #53472

The deprecated isSmall property is being used in the Button component and in the component that wraps the Button component.

I believe that the isSmall property should be replaced with size="prop" to officially deprecate it, as mentioned in this comment.

button-deprecated
@t-hamano t-hamano added the [Package] Components /packages/components label Aug 11, 2023
@t-hamano t-hamano mentioned this issue Aug 11, 2023
Merged
@mirka mirka added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality labels Aug 11, 2023
ddryo added a commit to ddryo/gutenberg that referenced this issue Aug 12, 2023
@ddryo
Replace isSmall prop WordPress#53560
03bd1bd
@ddryo ddryo mentioned this issue Aug 12, 2023
Merged
@chandima131 chandima131 mentioned this issue Sep 30, 2023
Closed
tkc49 added a commit to tkc49/gutenberg that referenced this issue Oct 20, 2023
@tkc49
WordPress#53560 change button property "isSmall" to "size"
0e65c0b
@tkc49 tkc49 mentioned this issue Oct 20, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 20, 2023
tkc49 added a commit to tkc49/gutenberg that referenced this issue Oct 20, 2023
@tkc49
WordPress#53560 Add CHANGELOG.md
880bc3c
@skorasaurus
Copy link
Member

Note isSmall is used in several other places and there's a PR to fix it at #53599

@mirka mirka linked a pull request Dec 15, 2023 that will close this issue
Replace isSmall prop #53560 #53599
Merged
@mirka mirka removed a link to a pull request Dec 18, 2023
Replace isSmall prop #53560 #53599
Merged
mirka added a commit that referenced this issue Dec 18, 2023
@ddryo @mirka
Replace isSmall prop #53560 (#53599)
df9f857 
Co-authored-by: Lena Morita <[email protected]>
artemiomorales pushed a commit that referenced this issue Jan 4, 2024
@ddryo @mirka @artemiomorales
Replace isSmall prop #53560 (#53599)
4182f26 
Co-authored-by: Lena Morita <[email protected]>
inc2734 added a commit to inc2734/gutenberg that referenced this issue Feb 23, 2024
@inc2734
Replace isSmall prop WordPress#53560
434d062
@inc2734 inc2734 mentioned this issue Feb 23, 2024
Merged
inc2734 added a commit to inc2734/gutenberg that referenced this issue Feb 23, 2024
@inc2734
Replace isSmall prop WordPress#53560
a3b0418
@inc2734 inc2734 mentioned this issue Feb 23, 2024
Merged
@fabiankaegy fabiankaegy linked a pull request Feb 23, 2024 that will close this issue
Replace Navigator isSmall prop WordPress/gutenberg#53560 #59304
Merged
fabiankaegy added a commit that referenced this issue Feb 23, 2024
@inc2734 @fabiankaegy
Replace isSmall prop #53560 (#59304)
599f336 
Co-authored-by: inc2734 <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: skorasaurus<[email protected]>
@fabiankaegy
Copy link
Member

I can see there are more instances still. So reopening

@fabiankaegy fabiankaegy reopened this Feb 23, 2024
This was referenced Mar 3, 2024
Merged
Merged
@jaclync
Copy link
Contributor

jaclync commented Mar 7, 2024

I'm taking on this one.

@jaclync jaclync mentioned this issue Mar 7, 2024
Merged
@jaclync
Copy link
Contributor

jaclync commented Mar 7, 2024 •
edited
Loading

For future contributors, the remaining components to replace that I found:

  • SidesDropdown
  • PaletteEdit
  • ToolsPanelHeader

@t-hamano t-hamano linked a pull request Mar 7, 2024 that will close this issue
Replace isSmall prop WordPress/Gutenberg#53560 #59302
Merged
@t-hamano
Copy link
Contributor Author

t-hamano commented Mar 7, 2024

Once #59302 is merged, all isSmall props will be replaced and this issue can be closed. Thank you to everyone who worked on this issue!

t-hamano added a commit that referenced this issue Mar 9, 2024
@inc2734 @t-hamano @fabiankaegy
Replace isSmall prop #53560 (#59302)
4d9a27e 
Co-authored-by: inc2734 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: skorasaurus <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: jaclync <[email protected]>
This was referenced Mar 10, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
5 participants
@mirka @skorasaurus @jaclync @fabiankaegy @t-hamano