Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a post is already published, you can't preview it from a mobile device #8184

Closed
sarahmonster opened this issue Jul 24, 2018 · 14 comments · Fixed by #16496
Closed

If a post is already published, you can't preview it from a mobile device #8184

sarahmonster opened this issue Jul 24, 2018 · 14 comments · Fixed by #16496
Assignees
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@sarahmonster
Copy link
Member

2018-07-25 00 42 12

When a post is already published and you're viewing it at a small screen size (< 600 pixels wide) the "preview" button disappears, and there doesn't seem to be anywhere else it can be accessed.

Tested in Firefox and Chrome on a Mac.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Jul 25, 2018
@designsimply
Copy link
Member

Tested and confirmed using Firefox 61.0.1 with Responsive Design Mode for iPhone 6S on macOS 10.13.6.

screen shot 2018-07-24 at tue jul 24 8 30 49 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=14022&action=edit running WordPress 4.9.7 and Gutenberg 3.3.0 using Firefox 61.0.1 on macOS 10.13.6.

@designsimply designsimply added [Feature] UI Components Impacts or related to the UI component system and removed [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Aug 15, 2018
@designsimply designsimply added this to the 3.6 milestone Aug 15, 2018
@youknowriad youknowriad added Needs Design Needs design efforts. and removed [Type] Bug An existing feature does not function as intended labels Aug 15, 2018
@youknowriad
Copy link
Contributor

I believe this was "by design". Adding a "Need Design" label to see if we want this button in mobile and where.

@youknowriad youknowriad removed this from the 3.6 milestone Aug 15, 2018
@karmatosed karmatosed added this to the WordPress 5.0.1 milestone Nov 22, 2018
@karmatosed
Copy link
Member

This should have an iteration and work done to add back in for mobile. Preview for now can be done through the permalinks option in the document once published, however that isn't a long term solution. I'm putting to 5.0.1 as it can be reached but should be added to toolbar. Designs around how that fits in would be great to see.

@karmatosed
Copy link
Member

A stop gap solution would be to simply have this:

2018-11-22 at 18 16

This does mean things are getting really crowded but it should at least make it more expected. As result putting to 4.6 but we can always move back. We should also really look at iterating this toolbar on smaller devices.

@karmatosed karmatosed modified the milestones: WordPress 5.0.1, 4.6 Nov 22, 2018
@noisysocks noisysocks self-assigned this Nov 22, 2018
@noisysocks
Copy link
Member

The problem is that it doesn't all fit into a 320px viewport, e.g. on an iPhone SE:

localhost_8888_wp-admin_post php_post 111 action edit iphone 5_se

I suspect, too, that the Switch to Draft button appears wider in German or French.

@noisysocks noisysocks removed their assignment Nov 23, 2018
@karmatosed
Copy link
Member

karmatosed commented Nov 23, 2018

This makes me even more sure need to iterate this toolbar after 5.0, thanks for showing that @noisysocks. There are a few options available to us:

  • Removing 'switch to draft' on mobile.
  • Iterating the text and shortening it to 'Draft'.
  • Leave as is for now.

I don't think the text shortening works as it becomes hard to understand the action.

cc @jasmussen and @mtias for some thoughts on if we have a stop-gap solution now or wait and iterate.

@jasmussen
Copy link
Contributor

I think it's good to improve this menu post 5.0, but I don't personally think this stuff is urgent. I can definitely be convinced otherwise, but it doesn't seem critical to me that you can't preview a published post on mobile — already now preview can be seen as less important with the editor potentially looking almost identical to the frontend, and given the state of the post is published, the preview is less valuable. That's not to say it shouldn't be there, just an argument for why it can wait until after 5.0 IMO.

@mtias mtias modified the milestones: 4.6, WordPress 5.0.1 Nov 28, 2018
@kjellr
Copy link
Contributor

kjellr commented Jan 21, 2019

Iterating the text and shortening it to 'Draft'.

This seems like a good quick fix to me, and it fits on 320px screens.

iphone 8 1

It gets a little too crowded when the fullscreen exit button is present...

iphone 8

... but I'm not even sure that exit button should be there on small screens. 🤔

An alternate approach would be to remove "Switch to Draft" and place it in the ellipsis menu on small screens. The ellipsis menu is meant to store overflow, right?

@jasmussen
Copy link
Contributor

Digging your "Draft" rephrasing a lot, Kjell, though perhaps "Save" might be even better? I think either is worth a PR.

... but I'm not even sure that exit button should be there on small screens. 🤔

I agree — if you've ever used Figma, you know how well autosave can work. Autosave is the future, and would allow us to eliminate this button both on mobile and desktops.

@kjellr
Copy link
Contributor

kjellr commented Jan 22, 2019

... but I'm not even sure that exit button should be there on small screens. 🤔

Whoops — looks like I uploaded the same image twice. I meant to upload this for the second one:

iphone 8 1

^ That's the exit button I'm referring to — it only shows up when fullscreen mode has been selected on desktop. As such, I don't think it's necessary on mobile. I'll open a PR. (EDIT: Turned out to be a little more complicated than just the exit button, but I opened a PR here to discuss: #13425)

In any case, "Save" is an interesting alternative for "Switch to Draft". I wonder if that'd be confusing though? Since it's not technically saving — it's switching to a draft and then saving? (To be honest, this whole "Switch to draft" flow in WP has always confused me. 😄).

@jasmussen
Copy link
Contributor

Ah sorry, forgot tto comment on that. Yeah we should not be showing that on mobile, because mobile is by definition fullscreen. Totally just hide that, including the menu option, at the mobile breakpoint. We do the same for many other options.

@kjellr
Copy link
Contributor

kjellr commented Mar 19, 2019

Wanted to leave another note in favor of changing the "Switch to Draft" button to say "Draft" on mobile. It's worth noting that if a user were to click that and not understand what it means, there is a modal that appears to confirm their action:

Screen Shot 2019-03-19 at 3 30 08 PM

I do think that "Draft" gives the user just enough context, but in the case it doesn't, this modal would help clear things up after clicking the link.

@jasmussen
Copy link
Contributor

Yep, dig that Kjell.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Apr 15, 2019
@noisysocks noisysocks self-assigned this Jul 10, 2019
@noisysocks
Copy link
Member

Took a crack at this in #16496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants