Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Preview button on mobile viewports #16496

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Show Preview button on mobile viewports #16496

merged 1 commit into from
Jul 10, 2019

Conversation

noisysocks
Copy link
Member

Fixes #8184.

localhost_8888_wp-admin_post php_post=13 action=edit(iPhone 6_7_8)

Displays the Preview button and renames Switch to Draft to Draft on mobile viewports. This allows mobile users to easily preview their published posts.

To test:

  1. Create a new post
  2. Click Publish... and publish the post
  3. On a mobile viewport, confirm that you now see a Preview button

@noisysocks
Show Preview button on mobile viewports
a3e05c1 
Displays the Preview button and renames 'Switch to Draft' to 'Draft' on
mobile viewports. This allows mobile users to easily preview their
published posts.
@noisysocks noisysocks added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. Mobile Web Viewport sizes for mobile and tablet devices labels Jul 10, 2019
@noisysocks noisysocks mentioned this pull request Jul 10, 2019
Closed
@noisysocks noisysocks added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Jul 10, 2019
@youknowriad youknowriad added the Needs Design Feedback Needs general design feedback. label Jul 10, 2019
jorgefilipecosta
jorgefilipecosta approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on my tests, and the code changes look good 👍

kjellr
kjellr approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @noisysocks! I tested across a number of common mobile breakpoints, and this works well in all of them. 🚢

@karmatosed
Copy link
Member

This is great @noisysocks - let's ship!

@karmatosed karmatosed merged commit 1731607 into master Jul 10, 2019
@github-actions github-actions bot added this to the Gutenberg 6.2 milestone Jul 10, 2019
@kjellr kjellr deleted the update/show-post-preview-button-on-mobile branch July 10, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@kjellr kjellr kjellr approved these changes

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Mobile Web Viewport sizes for mobile and tablet devices Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 6.2
Development

Successfully merging this pull request may close these issues.

If a post is already published, you can't preview it from a mobile device
5 participants
@noisysocks @karmatosed @kjellr @jorgefilipecosta @youknowriad