-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update browserlist package to fix test errors #13395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all tests pass 👍
@karmatosed, @jasmussen or @mapk - can you spot any visual differences in the editor with these changes applied? In theory, there should be no change, it should only contain some optimizations in the generated CSS. I can't spot any issues on Chrome. I only can see some very small tweaks in the produced CSS when comparing old and new CSS. |
@afercia, I know you use IE, can you double check it doesn't regress with the additional commit applied? |
Took this for a quick spin and did not see any regressions 👍 👍 |
I do, but only for testing purposes on a second laptop. I'll try to test it as soon as I have some spare time. |
I don't really expect breakage and we have time to merge and test properly before 5.0 |
Thanks for help everyone 🥇 |
* Chore: Update browserlist package to fix test errors * Update more dependencies to ensure that browserslit uses the latest version
* Chore: Update browserlist package to fix test errors * Update more dependencies to ensure that browserslit uses the latest version
Description
Fixes issue with the failing unit tests caused by one of the dependencies being out of date. As explained in detail by @afercia in #13385 (comment):
In addition, I updated the following dependencies which also were using the outdated
browserlist
andcaniuse-lite
packages:"autoprefixer": "^9.4.5"
"postcss": "^7.0.13"
"stylelint": "^9.10.1"
First two dependencies had breaking changes so it causes some differences in the generated CSS code. In theory, it should be safe as they claim it should have the only impact on the code, because they claim to provide backward compatibility for IE:
There is a similar note for PostCSS.
How has this been tested?
npm test
npm run build