Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isShallowEqual documentation and unit tests by deep comparison #13526

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Update isShallowEqual documentation and unit tests by deep comparison #13526

merged 2 commits into from
Jan 28, 2019

Conversation

Naerriel
Copy link
Contributor

Description

This PR solves #7801.
It updates isShallowEqual documentation and unit tests by deep comparison.

How has this been tested?

Ran npm run test.

Screenshots

Types of changes

Update of documentation
Update of unit tests

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

aduth
aduth reviewed Jan 27, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I really like the idea of providing a contrasted description from deep equality, and in ensuring via testing that the module doesn't accidentally implement deep equality.

packages/is-shallow-equal/README.md Outdated Show resolved Hide resolved
aduth
aduth approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement 👍

@aduth aduth merged commit 98b1350 into WordPress:master Jan 28, 2019
This was referenced Feb 4, 2019
Merged
Closed
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@Naerriel @youknowriad
Update isShallowEqual documentation and unit tests by deep comparison (…
57e6f74 
…#13526)

* Update isShallowEqual documentation and unit tests by deep comparison

* Update packages/is-shallow-equal/README.md

Co-Authored-By: Naerriel <[email protected]>
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@Naerriel @youknowriad
Update isShallowEqual documentation and unit tests by deep comparison (…
f728cac 
…#13526)

* Update isShallowEqual documentation and unit tests by deep comparison

* Update packages/is-shallow-equal/README.md

Co-Authored-By: Naerriel <[email protected]>
@aduth aduth mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naerriel @aduth