Fix: Sibling inserter adds block in the wrong position if a block is selected #14107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
jorgefilipecosta
added
[Type] Bug
youknowriad
reviewed
Feb 26, 2019
| rootClientId, | ||
| } = getInsertionPoint(); | ||
| if ( | ||
| ! isAppender && |
There was a problem hiding this comment.
This check is probably useless now.
|
The changes did in #14020 also solved the bug this PR was intended to solve. I'm closing this PR as it is not needed anymore. |
jorgefilipecosta
deleted the
fix/sibling-inserter-inserts-at-wrong-position-if-a-block-is-selected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an empty paragraph block was selected the sibling inserter inserted the block at the position where the empty paragraph block was instead of inserting in the position the sibling inserter is being rendered.
Fixes: #14087
props to @pilou for reporting this issue.
How has this been tested?
I created 4 empty paragraph blocks, with an empty gallery and an image after.
I selected one of the empty paragraph blocks.
I passed the mouse over the image and made the sibling inserter appear between the gallery and the image block.
I added the latest posts block using the sibling inserter and I verified the block was added in the middle of the gallery and the image as expected.
Screenshots
Before:
After:
