Update dynamic blocks documentation #16450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request. Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.
jodamo5
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz and
youknowriad
as code owners
|
One of the tests failed, but seems like a mistake, as no code was actually changed on this file - just text changes. Can someone look into this please? |
|
@jodamo5 We had some issues with the tests yesterday. I restarted them and now they are fine :-) |
|
Thanks @Soean. Tests have passed. Can someone please merge this in? Thanks. |
mkaz
reviewed
Jul 12, 2019
docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md
Outdated
Show resolved
Hide resolved
…creating-dynamic-blocks.md Example added showing how to save InnerBlocks. Co-Authored-By: Marcus Kazmierczak <[email protected]>
mkaz
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16374 Description
Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request. Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.
How has this been tested?
Most changes here are simply text changes to improve the understanding. The InnerBlocks explanation has been tested on both development and live sites.
Types of changes
Just further explanations in the documentation.