Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass 'image' instead of 'image-type' as type param for MediaUploadButton component #1682

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Pass 'image' instead of 'image-type' as type param for MediaUploadButton component #1682

merged 1 commit into from
Jul 4, 2017

Conversation

westonruter
Copy link
Member

It seems image was accidentally replaced with format-image in 255dbe5. The MediaUploadButton component takes a type prop which is the MIME type.

Compare with the gallery and cover-image blocks:

Fixes #1653.

@westonruter westonruter added [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended labels Jul 4, 2017
@jasmussen
Copy link
Contributor

Hooray! I don't seem to be able to reproduce the issue I described in #1653! Thansk for working on this. 👍 👍

youknowriad
youknowriad approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and sorry for the breakage

@westonruter westonruter merged commit 83ec880 into master Jul 4, 2017
@westonruter westonruter deleted the fix/image-block-media-library-type-query branch July 4, 2017 15:49
@westonruter westonruter mentioned this pull request Jul 7, 2017
Closed
Tug pushed a commit that referenced this pull request Jan 16, 2020
@lukewalczak
Style fixes after navigation merge (#1682)
9e8196a 
* Add ref to gutenberg repo
@snyk-bot snyk-bot mentioned this pull request Nov 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @jasmussen @youknowriad