Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox alignment issues in options and block manager modals (#16860) #16863

Merged
merged 9 commits into from
Aug 9, 2019
Merged

Fix checkbox alignment issues in options and block manager modals (#16860) #16863

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
24bfbc9
Fix checkbox alignment issues in options and block manager modals
jffng Aug 1, 2019
de682a0
replace media query with mixin
jffng Aug 2, 2019
f3312ca
Set height of label
jffng Aug 2, 2019
f7de824
Refactor checkmark and input in single container
jffng Aug 5, 2019
6b0a212
Move variables to global stylesheets
jffng Aug 5, 2019
addf8f3
make checkbox input size variables local to component styles
jffng Aug 6, 2019
52bcc30
Merge branch 'fix/misplaced-checkmarks'
jffng Aug 8, 2019
60aaaa0
Merge branch 'master' of github.com:WordPress/gutenberg
jffng Aug 8, 2019
09d5242
rebase master and update snapshots
jffng Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/checkbox-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ svg.dashicon.components-checkbox-control__checked {
pointer-events: none;
}

@media screen and ( max-width: 728px ) {
@media screen and ( max-width: 600px ) {
kjellr marked this conversation as resolved.
Show resolved Hide resolved
.components-checkbox-control__input[type="checkbox"] {
width: 25px;
height: 25px;
Expand Down
9 changes: 9 additions & 0 deletions packages/edit-post/src/components/manage-blocks-modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
top: 0;
padding: $panel-padding 0;
background-color: $white;
z-index: 1;
kjellr marked this conversation as resolved.
Show resolved Hide resolved

.components-base-control__field {
margin-bottom: 0;
Expand Down Expand Up @@ -86,6 +87,14 @@
align-items: center;
display: flex;
margin: 0;
svg.dashicon.components-checkbox-control__checked {
bottom: 5px;
left: -37px;
@include break-small() {
bottom: 10px;
left: -27px;
}
}
}

.components-modal__content & input[type="checkbox"] {
Expand Down
6 changes: 6 additions & 0 deletions packages/edit-post/src/components/options-modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@
align-items: center;
display: flex;
margin: 0;
svg.dashicon.components-checkbox-control__checked {
bottom: 0;
@include break-small() {
bottom: 5px;
}
}
}

&.components-base-control + &.components-base-control {
Expand Down