-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stylelint
and stylelint-config-wordpress
#16985
Conversation
hmm. I'm getting an error when I check out this branch, run [email protected] lint-css /Users/---/WebProjects/vvv/www/wordpress-one/public_html/wp-content/plugins/gutenberg
> wp-scripts lint-style '**/*.scss'
internal/modules/cjs/loader.js:638
throw err;
^
Error: Cannot find module 'stylelint'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
at Function.resolve (internal/modules/cjs/helpers.js:33:19)
at sync (/Users/---/WebProjects/vvv/www/wordpress-one/public_html/wp-content/plugins/gutenberg/node_modules/resolve-bin/index.js:60:21)
at Object.<anonymous> (/Users/---/WebProjects/vvv/www/wordpress-one/public_html/wp-content/plugins/gutenberg/packages/scripts/scripts/lint-style.js:46:2)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12) |
I'm also getting a
|
@nerrad Do you have a Removing that folder and running |
It looks like the issue @nerrad has is legitimate: I don't see I still want to test whether manual version change in the corresponding |
Strange, as I did follow the new process to to update the lock file, I had to do this a half dozen times to get it right, the lock file in this PR appears to have the changes I would expect to see:
I probably won't have time to look at this before the end of the week, so if anyone feels like playing some package lock debug, feel free to 😏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to make Travis happy before we can land it.
@@ -51,8 +51,8 @@ | |||
"read-pkg-up": "^1.0.1", | |||
"resolve-bin": "^0.4.0", | |||
"source-map-loader": "^0.2.4", | |||
"stylelint": "^9.10.1", | |||
"stylelint-config-wordpress": "^13.1.0", | |||
"stylelint": "^10.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include some notes in the package's CHANGELOG file?
New pull request to replace this one in #19370 19370 |
Description
Updates the stylelint dependencies
How has this been tested?
Running
npm run lint-css
from the repo rootScreenshots
Types of changes
Checklist: