Update github action exit codes #17002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Task
|
Looks like |
ntwb
approved these changes
Aug 13, 2019
talldan
force-pushed
the
try/github-action-error-codes
branch
from
e630cd2 to
45890eb
Compare
noisysocks
reviewed
Aug 15, 2019
|
|
||
| action=$(jq -r '.action' $GITHUB_EVENT_PATH) | ||
|
|
||
| if [ "$action" != 'closed' ]; then |
There was a problem hiding this comment.
This should be 'opened'. The idea is that we assign any fixed issues to the author of a PR when that PR is opened.
There was a problem hiding this comment.
Yeah, that was a typo 😓
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Update github action exit codes * Remove Filter Opened from github actions
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Update github action exit codes * Remove Filter Opened from github actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github actions used to support an exit code of
78to indicate that an action is neutral (has no effect, but any subsequent actions shouldn't run):https://developer.github.com/actions/creating-github-actions/accessing-the-runtime-environment/#exit-codes-and-statuses
It looks like neutral exit code have been dropped from the new version of actions, they need to return
0to indicate success, or will show as a big red ❌against PRs:https://help.github.com/en/articles/virtual-environments-for-github-actions#exit-codes-and-statuses
How has this been tested?
This PR should hopefully have a green check for each action ✅
Types of changes
Task
Checklist: