Fix: Duplicate button appears even if the block is not allowed #17007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
requested review from
ellatrix,
talldan and
youknowriad
as code owners
swissspidy
approved these changes
Aug 14, 2019
jorgefilipecosta
deleted the
fix/duplicate-button-appears-even-if-the-block-is-not-allowed
branch
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master, the duplicate button appears even if the block is not allowed, although clicking on it does nothing.
How has this been tested?
I added a paragraph block.
I went to the block manager.
I disabled the paragraph block.
I tried to duplicate the paragraph block but verified the button was not available as expected. On master, the button is available but does nothing.
Screenshots