Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the double scrollbar appearing in full screen mode #17031

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

youknowriad
Copy link
Contributor

Fix regression introduced by #16856

The fact that "border-box: sizing" is not applied consistently now across all the elements cause this unnecessary scrollbar to show up in the full-screen mode.

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Aug 14, 2019
@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 14, 2019
@youknowriad youknowriad requested a review from talldan as a code owner August 14, 2019 09:12
@youknowriad youknowriad self-assigned this Aug 14, 2019
Copy link
Contributor

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM
screenshot
image

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed! Very nice catch.

Tested with and without fullscreen mode, and other configurations, including mobile, top toolbar and various breakpoints. Ship it.

@youknowriad youknowriad merged commit 9c4ee6f into master Aug 14, 2019
@youknowriad youknowriad deleted the fix/double-scrollbar-fullscreen branch August 14, 2019 09:41
@jasmussen
Copy link
Contributor

💥

Thank you Riad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants