Fixes missing default funcs as props in BlockEditorProvider
#17036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the component assumed that the onChange and onInput props would always be present. However, there are times where this may not be the case such as when the BlockPreview component uses the provider to render the previews. In such cases `onChange` is called but is undefined which causes an error to be thrown. To avoid this we provide lodash noop as defaults for both “change” props.
3 tasks
youknowriad
approved these changes
Aug 15, 2019
getdave
deleted the
fix/block-editor-provider-ensure-default-change-props
branch
jeremyfelt
added a commit
to bu-ist/bu-blocks
that referenced
this pull request
Aug 26, 2019
In the latest version of WordPress and Gutenberg, it's possible the `onChange` function does not exist by default on block components. This change checks that `onChange` is callable before attempting to call it. This will likely be fixed in future versionso of Gutenberg via WordPress/gutenberg#17036, but it won't hurt to have a fallback check here.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Previously the component assumed that the onChange and onInput props would always be present. However, there are times where this may not be the case such as when the BlockPreview component uses the provider to render the previews. In such cases `onChange` is called but is undefined which causes an error to be thrown. To avoid this we provide lodash noop as defaults for both “change” props.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
Previously the component assumed that the onChange and onInput props would always be present. However, there are times where this may not be the case such as when the BlockPreview component uses the provider to render the previews. In such cases `onChange` is called but is undefined which causes an error to be thrown. To avoid this we provide lodash noop as defaults for both “change” props.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component assumes that the
onChangeandonInputprops are always present. However, there are times where this may not be the case such as when theBlockPreviewcomponent uses the provider to render the previews. In such casesonChangeis called but isundefinedwhich causes an error to be thrown.To avoid this we provide lodash
noopas defaults for both “change” props.An example of when an error is thrown can be seen in this PR
Automattic/wp-calypso#35333
Questions
isFunctionas well?noopa good default?How has this been tested?
Running this branch against Automattic/wp-calypso#35333 causes the error related to
onChangeto disappear.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: