TinyMCE per block: Using a simpler grammar parser #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
force-pushed
the
update/per-block/new-grammar-parser
branch
from
ddde4ba to
1f02d59
Compare
|
Did you modify the grammar manually or did you work from https://github.com/Automattic/wp-post-grammar ? Just wondering if we'll want to push upstream changes. |
|
@aduth Here's the PR for the grammar change Automattic/wp-post-grammar#13 |
nylen
pushed a commit
that referenced
this pull request
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I simplified the grammar avoiding HTML parsing by the grammar, this fixes a lot of issues and make the editor code simpler.
Here's the PR to update the grammar Automattic/wp-post-grammar#13