Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Controls: Docs: Fix syntax errors and inaccurate usage example for dispatch data control #17773

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 4, 2019

This pull request seeks to improve the documentation for the @wordpress/data-controls package in two ways:

  • Fix an inaccuracy with the usage of dispatch as receiving multiple arguments (vs. the store key and returning an object of action dispatchers)
  • Resolve syntax errors, notably with the generator function declaration

Testing Instructions:

As these changes purely impact documentation, there should be no runtime impact.

@aduth aduth added [Type] Developer Documentation Documentation for developers [Package] Data Controls /packages/data-controls labels Oct 4, 2019
@aduth aduth requested a review from nerrad October 4, 2019 15:08
Copy link
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Those were pretty bad errors, thanks for the fix!

@youknowriad
Copy link
Contributor

So bad at being AFK :)

@epiqueras epiqueras merged commit 9030e51 into master Oct 4, 2019
@epiqueras epiqueras deleted the update/data-controls-doc-syntax branch October 4, 2019 20:53
@youknowriad youknowriad added this to the Gutenberg 6.7 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Data Controls /packages/data-controls [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants