Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Fix typo in the blockPatterns reducer #18781

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Blocks: Fix typo in the blockPatterns reducer #18781

merged 1 commit into from
Nov 27, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 27, 2019

Description

This should fix the copy and paste issues raised by @mcsf in #18270 (comment):

I think this should read ( pattern ) => pattern.name :)

I originally planned to fix it with refactor proposed in #18398. However, it looks like this is not going to happen.

@gziolo gziolo added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 27, 2019
@gziolo gziolo self-assigned this Nov 27, 2019
@gziolo gziolo requested a review from mcsf November 27, 2019 13:52
@gziolo gziolo added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Nov 27, 2019
mcsf
mcsf approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for remembering!

@gziolo gziolo merged commit 09cbff8 into master Nov 27, 2019
@gziolo gziolo deleted the update/block-patterns-reducer branch November 27, 2019 14:39
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcsf mcsf mcsf approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@gziolo gziolo

Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gziolo @mcsf @youknowriad