Block: Fix form element alignment for Embed + Table #19495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes the Input x Button alignment for both the Embed and Table blocks via the internal Placeholder component. The issue was caused by a recent update made to the base Placeholder component which normalized it's margins. However, due to the element/layout rendering of the Table block, it required certain margin values for the Placeholder button to align correctly. The solution was to revert the globalized changes, and apply the normalization specifically to the Embed block. I don't think this will be a permanent solution given how unpredictable component combinations may affect layout (via margin). For now, this solution is adequete to resolve these 2 Blocks.
ItsJonQ
added
[Type] Bug
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
Soean and
talldan
as code owners
|
The test failure is unrelated and I believe is being fixed separately. |
|
Looks like this is already fixed in master now right? |
Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the Input x Button alignment for both the Embed and
Table blocks via the internal Placeholder component.
The issue was caused by a recent update made to the base Placeholder
component which normalized its margins. However, due to the element/layout
rendering of the Table block, it required certain margin values for the
Placeholder button to align correctly.
The solution was to revert the globalized changes and apply the normalization
specifically to the Embed block.
I don't think this will be a permanent solution given how unpredictable
component combinations may affect the layout (via margin). For now, this
solution is adequate to resolve these 2 Blocks.
How has this been tested?
Tested locally in Gutenberg dev environment
Checklist:
Follow up to #19438