Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Fix Quote border-left not visible in Dark Mode #20419

Merged
merged 1 commit into from
Feb 26, 2020
Merged

[RNMobile] Fix Quote border-left not visible in Dark Mode #20419

merged 1 commit into from
Feb 26, 2020

Conversation

ceyhun
Copy link
Member

@ceyhun ceyhun commented Feb 24, 2020 •
edited
Loading

Description

Fixes wordpress-mobile/gutenberg-mobile#1673

Also addressed design feedback from here: #20265 (comment)

Gutenberg mobile PR: wordpress-mobile/gutenberg-mobile#1953

How has this been tested?

  1. Enable light mode
  2. Add Quote block
  3. Enable dark mode
  4. Check left border

Screenshots

iOS (light) iOS (dark) Android
ios-light ios-dark android-light

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ceyhun ceyhun changed the title Add dark mode support to BlockQuotation native component [RNMobile] Add dark mode support to BlockQuotation native component Feb 24, 2020
@ceyhun ceyhun changed the title [RNMobile] Add dark mode support to BlockQuotation native component [RNMobile] Fix Quote border-left not visible in Dark Mode Feb 24, 2020
@ceyhun ceyhun marked this pull request as ready for review February 25, 2020 16:49
@ceyhun ceyhun mentioned this pull request Feb 25, 2020
Merged
2 tasks
@SergioEstevao SergioEstevao self-assigned this Feb 25, 2020
@SergioEstevao SergioEstevao added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 25, 2020
SergioEstevao
SergioEstevao approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@SergioEstevao SergioEstevao merged commit 54877c1 into WordPress:master Feb 26, 2020
@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees

@SergioEstevao SergioEstevao

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.7
Development

Successfully merging this pull request may close these issues.

Quote border-left not visible in Dark Mode
2 participants
@ceyhun @SergioEstevao