Fix block selection indicator. #20459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: +24 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
fix/paragraph
branch
from
cf0caab to
3877f30
Compare
ellatrix
approved these changes
Feb 26, 2020
|
Thanks for the fast review, merging when the checks pass! |
jasmussen
force-pushed
the
fix/paragraph
branch
2 times, most recently
from
f7e59eb to
5be4940
Compare
The behavior of manipulating blocks in the recent G2 refresh regressed slightly in #19701, this PR addresses that. Specifically, the blue border is meant to indicate _block focus_, i.e. when it is present you can press Delete to remove the block. It is not meant to indicate the block boundaries when focus is inside text.
jasmussen
force-pushed
the
fix/paragraph
branch
from
5be4940 to
3a250f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of manipulating blocks in the recent G2 refresh regressed slightly in #19701, this PR addresses that.
Specifically, the blue border is meant to indicate block focus, i.e. when it is present you can press Delete to remove the block. It is not meant to indicate the block boundaries when focus is inside text.