Cleanup CSS variables #20529
Merged
Cleanup CSS variables #20529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: -11 B (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
jasmussen
reviewed
Feb 28, 2020
| @@ -1,11 +1,11 @@ | |||
| .block-editor-color-gradient-control { | |||
| &__color-indicator { | |||
| margin-bottom: $grid-size; | |||
| margin-bottom: $grid-unit; | |||
There was a problem hiding this comment.
I don't think we should ever actually use $grid-unit, it should always be one of the numbered ones. I.e. in this case, it should be $grid-unit-10.
In that vein, $grid-unit is intended only to seed all the numbered variables. Should it have a different name to reflect that?
There was a problem hiding this comment.
I updated but why not just remove the variable in that case and use $grid-unit-10 everywhere.
There was a problem hiding this comment.
Oh I guess that could work? Seems almost cyclical 😅
The alternative would be to spell out 8px for each variable.
jasmussen
reviewed
Feb 28, 2020
| @@ -48,7 +48,6 @@ | |||
|
|
|||
| // Ensure that the height of the first appender, and the one between blocks, is the same as text. | |||
| .block-editor-default-block-appender__content { | |||
| min-height: $empty-paragraph-height / 2; | |||
There was a problem hiding this comment.
I haven't had time to test this yet, are you sure there aren't any negataive consequences of removing this? I'm sure we added it for a reason, back in the day.
There was a problem hiding this comment.
The reason we added it is to make sure the appender with or without paragraph has the same height. It's broken with or without this style now.
There was a problem hiding this comment.
Not sure I follow but I'll check when I have a moment.
|
In general this is a really nice bit of cleanup, thank you. I promise I'll get to the color variable cleanup as well, perhaps in my color PR. I left two comments to address. |
youknowriad
requested review from
daniloercoli,
etoledom and
SergioEstevao
as code owners
youknowriad
force-pushed
the
update/css-variables
branch
from
80cc8c1 to
30c78f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleaning to our CSS variables.