-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the editor fullscreen by default #20611
Conversation
When I use the editor in its normal mode (not full-screen) I've essentially trained my eyes to ignore the wp-admin toolbar and sidebar. Removing these elements by default seems like a good move to me — especially so if we consider adding better ways to toggle the wp-admin elements. |
Yep, agreed. This change helps bring people into the editor without keeping all the other visual distractions. It provides so much more focus! |
Size Change: +6 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
The other efforts in #20603 help provide a nice connection between the two interfaces, helping enable this change. Outside of the space/focus related benefits this brings, there are some benefits to scrolling as well, especially visible on small screens, 13'' or smaller. |
More focus is fine, but somehow it was also great that you can quickly click through the admin menu. Directly from the editor. Wouldn't you have to rework the whole admin menu in this context? And above all please simplify :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me, and I verified if I clear local storage with window.localStorage.clear();
when I load the editor it loads in full screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. LGTM!
The following package versions were changed: @wordpress/e2e-test-utils: 4.3.0 -> 4.3.1 @wordpress/edit-post: 3.13.3 -> 3.13.4 This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611. Props youknowriad, mcsf, mapk. Fixes: #49574. git-svn-id: https://develop.svn.wordpress.org/trunk@47421 602fd350-edb4-49c9-b593-d223f7449a82
The following package versions were changed: @wordpress/e2e-test-utils: 4.3.0 -> 4.3.1 @wordpress/edit-post: 3.13.3 -> 3.13.4 This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611. Props youknowriad, mcsf, mapk. Fixes: #49574. git-svn-id: https://develop.svn.wordpress.org/trunk@47421 602fd350-edb4-49c9-b593-d223f7449a82
The following package versions were changed: @wordpress/e2e-test-utils: 4.3.0 -> 4.3.1 @wordpress/edit-post: 3.13.3 -> 3.13.4 This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611. Props youknowriad, mcsf, mapk. Fixes: #49574. Built from https://develop.svn.wordpress.org/trunk@47421 git-svn-id: http://core.svn.wordpress.org/trunk@47208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The following package versions were changed: @wordpress/e2e-test-utils: 4.3.0 -> 4.3.1 @wordpress/edit-post: 3.13.3 -> 3.13.4 This commit update allows the following PR to be part of trunk WordPress/gutenberg#20611. Props youknowriad, mcsf, mapk. Fixes: #49574. Built from https://develop.svn.wordpress.org/trunk@47421 git-svn-id: https://core.svn.wordpress.org/trunk@47208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
I'm not opposed to the change but this is extremely last-minute, and making a fairly substantive change to the editor's behavior hours before RC does not make much sense to me. Why couldn't this have waited for 5.5? |
Granted it's a bit late in the cycle but this change has been considered a quick win by release leads and not impactful as recent user tests have shown that it leads to better User experience. There's still the possibility to revert it if there's anything wrong about it. |
I am VERY opposed to this change and am deeply saddened by this happening so late in a release. One hour before RC1 you commit something that changes the way people's edit screen looks, and thus force loads of people to update training materials etc. I think this should be reconsidered for a next release and then properly discussed, and reverted as soon as possible now. |
Would you be so kind to make these data public? Specifically:
Making these data public would greatly help other contributors to make well informed judgments on this change. Thank you. |
Additional context for why to include this, even if late in the process, is being discussed in https://make.wordpress.org/core/2020/03/03/fullscreen-mode-enabled-by-default-in-the-editor/ |
Commented there, thanks for the note @youknowriad |
It is too late to add this feature during a RC, and it should be punted to WordPress 5.5. |
Hi @paaljoachim,
This PR is not adding the feature. The feature already existed; this PR is just enabling it by default for users that don't have a preference for fullscreen currently set on their local storage. |
Hi Jorge. @jorgefilipecosta Thank you for the response! I phrased it in the wrong way. I should instead have said adding a visual UI change this late should not be allowed, but rather given more time to do research on how this will affect new users. Anyhow it needs a good discussion and hopefully that will be done during Wednesdays Dev Slack chat. |
@feastdesignco it would help if you showed the source of this little piece of research? I assume you didn't do it in the "I hate the block editor group" but where you did it does kind of matter :P |
@jdevalk I removed personally identifiable information from the responses for privacy reasons, but I'd be happy to share the source privately for verification with @youknowriad and the reviewers involved here. Email skylar@ our domain dot com |
It is annoying it reverts back to fullscreen mode allways after cookies (or what) expire. Why force it ? |
We had a lot of feedback suggesting that the Fullscreen mode is a better experience and that it should be enabled by default.
Let's explore this in the plugin for a few releases. Thoughts?