Try: Show inserter only when block selected for nesting contexts. #20753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +137 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
mtias
reviewed
Mar 10, 2020
| @@ -8,6 +8,12 @@ | |||
| .has-background & { | |||
| margin: ($grid-unit-20 + $block-spacing) $grid-unit-10; | |||
| } | |||
|
|
|||
| // Animate appearance. | |||
There was a problem hiding this comment.
I think we should consolidate these with react-spring cc @youknowriad
mtias
approved these changes
Mar 10, 2020
Starts work on #20728. It doesn't completely fix it though. What it does is create a generic rule to hide the appender in nesting contexts, until the parent or a child of the same block, is selected.
jasmussen
force-pushed
the
try/show-single-inserter-when-parent-selected
branch
from
cb92529 to
6f21762
Compare
jasmussen
commented
Mar 10, 2020
| @@ -24,3 +30,13 @@ | |||
| .block-list-appender > .block-editor-inserter { | |||
| display: block; | |||
| } | |||
|
|
|||
|
|
|||
| // Hide the nested appender unless parent or child is selected. | |||
There was a problem hiding this comment.
This PR was created just prior to #20729, and did not account for "lighter DOM" blocks. Serendipitously, such a block was just merged, meaning the rebase caught an issue.
The selector is now slightly more complex, but I've added additional context to explain it.
jasmussen
added a commit
that referenced
this pull request
Mar 11, 2020
In #20753 I caused a regression that collapsed the big square appender that exists in an empty columns block, or an empty group block. The only thing that should collapse, until selected, is the black appender button inside blocks like Social Links, Buttons, or Navigation Menu. This PR fixes that regression by scoping the animation to said button.
jasmussen
added a commit
that referenced
this pull request
Mar 11, 2020
In #20753 I caused a regression that collapsed the big square appender that exists in an empty columns block, or an empty group block. The only thing that should collapse, until selected, is the black appender button inside blocks like Social Links, Buttons, or Navigation Menu. This PR fixes that regression by scoping the animation to said button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts work on #20728. It doesn't completely fix it though.
What it does is create a generic rule to hide the appender in nesting contexts, until the parent or a child of the same block, is selected.
Not yet addressed is the addition of a label. A behavior of the columns block that used to show the plus in arbitrary situations has not been touched, as that issue does not appear to be present in master anymore.