-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make navigation block submenus usable on mobile. #21471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
An existing feature does not function as intended
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Mobile Web
Viewport sizes for mobile and tablet devices
Needs Design Feedback
Needs general design feedback.
[Block] Navigation
Affects the Navigation Block
labels
Apr 8, 2020
tellthemachines
requested review from
draganescu,
adamziel,
noisysocks and
talldan
April 8, 2020 06:12
tellthemachines
requested review from
ajitbohra,
jorgefilipecosta and
Soean
as code owners
April 8, 2020 06:12
tellthemachines
force-pushed
the
fix/responsive-nav-submenus
branch
from
April 8, 2020 07:42
b2995ed
to
33ab063
Compare
Size Change: -506 B (0%) Total Size: 889 kB
ℹ️ View Unchanged
|
karmatosed
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I think it's a great iteration. I think there probably are even more things we can do to soothe with this, but let's start here. Removing the design feedback label as for now works.
This was referenced Apr 15, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Mobile Web
Viewport sizes for mobile and tablet devices
Needs Design Feedback
Needs general design feedback.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navigation submenus are currently broken on mobile:
This PR adjusts submenu size and placement for small screens, and introduces text wrapping, to avoid horizontal scrolling. It also places the submenu indicator icon outside the menu item link, so that it is possible to open it on a touchscreen without activating the link.
How has this been tested?
Tested on multiple browsers and mobile simulators.
Screenshots
Types of changes
Checklist: