Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop removing tables on paste #2199

Merged
merged 2 commits into from
Aug 4, 2017
Merged

Stop removing tables on paste #2199

merged 2 commits into from
Aug 4, 2017

Conversation

georgeh
Copy link
Contributor

@georgeh georgeh commented Aug 3, 2017

Tables are working now, thanks to some updates in master. This re-enables them and deals with some errors from the way Pages copies them.

They are working now, thanks to some updates in master
@georgeh georgeh added [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement. labels Aug 3, 2017
@codecov
Copy link

codecov bot commented Aug 3, 2017

Codecov Report

Merging #2199 into master will increase coverage by 0.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
+ Coverage    22.5%   22.72%   +0.22%     
==========================================
  Files         139      140       +1     
  Lines        4332     4444     +112     
  Branches      729      762      +33     
==========================================
+ Hits          975     1010      +35     
- Misses       2833     2888      +55     
- Partials      524      546      +22
Impacted Files Coverage Δ
blocks/api/paste.js 60% <0%> (ø) ⬆️
blocks/api/paste/strip-attributes.js 0% <0%> (ø) ⬆️
editor/index.js 0% <0%> (ø) ⬆️
editor/inserter/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️
editor/utils/tracking.js 91.3% <0%> (ø)
editor/enable-tracking-prompt/index.js 100% <0%> (ø)
editor/actions.js 39.28% <0%> (+2.24%) ⬆️
components/button/index.js 93.75% <0%> (+2.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9deeb8...5a8edfe. Read the comment docs.

@georgeh georgeh requested a review from ellatrix August 3, 2017 19:56
@georgeh georgeh removed the [Status] In Progress Tracking issues with work in progress label Aug 3, 2017
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified I can paste in some HTML with tables in to a custom HTML block

Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@georgeh georgeh merged commit 20be975 into master Aug 4, 2017
@georgeh georgeh deleted the update/enable-pasting-tables branch August 4, 2017 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants