Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stats tracking code #2278

Merged
merged 11 commits into from
Aug 10, 2017
Merged

Remove stats tracking code #2278

merged 11 commits into from
Aug 10, 2017

Conversation

nylen
Copy link
Member

@nylen nylen commented Aug 7, 2017

  • Convert EnableTrackingPrompt tests to use shallow rendering - Add opt-in usage tracking for blocks added to post content #2140 (comment)
  • Restructure bumpStat calls inside components: dispatch a Redux action, and bump the stat as a refx effect
  • Improve the click-outside setup for the EnableTrackingPrompt popover
  • Abstract the click-to-show Popover logic into a separate component (InlineHelpPopover)

@nylen nylen added the [Status] In Progress Tracking issues with work in progress label Aug 7, 2017
@nylen
Copy link
Member Author

nylen commented Aug 7, 2017

Convert EnableTrackingPrompt tests to use shallow rendering

As noted at #2140 (comment), this isn't working for me for all of the tests.

@nylen nylen force-pushed the improve/tracking-code branch from 4847acb to f34d35d Compare August 7, 2017 23:20
@codecov
Copy link

codecov bot commented Aug 7, 2017

Codecov Report

Merging #2278 into master will increase coverage by 2.65%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
+ Coverage   24.96%   27.61%   +2.65%     
==========================================
  Files         151      151              
  Lines        4679     5396     +717     
  Branches      795      961     +166     
==========================================
+ Hits         1168     1490     +322     
- Misses       2965     3277     +312     
- Partials      546      629      +83
Impacted Files Coverage Δ
blocks/api/parser.js 98.66% <ø> (-1.34%) ⬇️
editor/index.js 0% <ø> (ø) ⬆️
editor/inserter/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️
editor/utils/url.js 50% <0%> (-16.67%) ⬇️
blocks/library/code/index.js 40% <0%> (-10%) ⬇️
blocks/library/verse/index.js 28.57% <0%> (-8.93%) ⬇️
blocks/library/preformatted/index.js 37.5% <0%> (-6.95%) ⬇️
blocks/library/table/index.js 30% <0%> (-6.37%) ⬇️
blocks/api/paste.js 54.54% <0%> (-5.46%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7033d5...e5f4eec. Read the comment docs.

@nylen
Copy link
Member Author

nylen commented Aug 8, 2017

This should be a reasonable foundation for #2191, but I still can't figure out how to get the tests to work using shallow instead of mount. @aduth maybe you can explain what I am missing there?

@nylen nylen changed the title Further improvements to tracking code Remove stats tracking code; add InlineHelpPopover component Aug 8, 2017
@nylen
Copy link
Member Author

nylen commented Aug 8, 2017

I've updated this PR by request to remove the tracking code.

@nylen nylen force-pushed the improve/tracking-code branch from f2bfa21 to 0ceb127 Compare August 8, 2017 17:49
@nylen nylen force-pushed the improve/tracking-code branch from 0ceb127 to d8bc28c Compare August 8, 2017 18:22
@nylen nylen removed the [Status] In Progress Tracking issues with work in progress label Aug 8, 2017
@@ -0,0 +1,80 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing tracking now, might we also ought remove this component? (YAGNI)

At very least, Popover usage has since changed and has isOpen prop:

https://github.com/WordPress/gutenberg/tree/master/components/popover

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in e5f4eec.

@nylen nylen changed the title Remove stats tracking code; add InlineHelpPopover component Remove stats tracking code Aug 9, 2017
@nylen nylen merged commit a6d1761 into master Aug 10, 2017
@nylen nylen deleted the improve/tracking-code branch August 10, 2017 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants