-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stats tracking code #2278
Conversation
As noted at #2140 (comment), this isn't working for me for all of the tests. |
4847acb
to
f34d35d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2278 +/- ##
==========================================
+ Coverage 24.96% 27.61% +2.65%
==========================================
Files 151 151
Lines 4679 5396 +717
Branches 795 961 +166
==========================================
+ Hits 1168 1490 +322
- Misses 2965 3277 +312
- Partials 546 629 +83
Continue to review full report at Codecov.
|
InlineHelpPopover
component
I've updated this PR by request to remove the tracking code. |
f2bfa21
to
0ceb127
Compare
…ndering" This reverts commit 861218db4398645b338f23c613fa579aa298ed09.
0ceb127
to
d8bc28c
Compare
@@ -0,0 +1,80 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're removing tracking now, might we also ought remove this component? (YAGNI)
At very least, Popover
usage has since changed and has isOpen
prop:
https://github.com/WordPress/gutenberg/tree/master/components/popover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in e5f4eec.
InlineHelpPopover
component
EnableTrackingPrompt
tests to useshallow
rendering - Add opt-in usage tracking for blocks added to post content #2140 (comment)bumpStat
calls inside components: dispatch a Redux action, and bump the stat as arefx
effectclick-outside
setup for theEnableTrackingPrompt
popoverPopover
logic into a separate component (InlineHelpPopover
)