useDisplayBlockControls: add missing useSelect dependency. #23249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Bug
ZebulanStanphill
added
the
Good First Review
|
Size Change: +1 B Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jun 18, 2020
|
Rebase and merge? |
ZebulanStanphill
force-pushed
the
fix/use-display-block-controls-missing-use-select-dependency
branch
from
02fb11f to
7575854
Compare
ZebulanStanphill
deleted the
fix/use-display-block-controls-missing-use-select-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a missing dependency to the
useSelectcall in theuseDisplayBlockControlshook. This might fix some obscure bugs, but even if not, it's still a good idea to harden this code against potential future bugs by making this change.