Update navigation placeholder label #23297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
Soean and
talldan
as code owners
tellthemachines
added
[Block] Navigation
|
Size Change: -192 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
tellthemachines
force-pushed
the
fix/nav-block-label
branch
from
40846c1 to
de75c12
Compare
|
cc. @shaunandrews for some design eyes. I tested this locally and noticed two things were a bit off:
|
|
Just noting, given the explorations in #23207 this select box might disappear. |
noisysocks
approved these changes
Jul 1, 2020
tellthemachines
force-pushed
the
fix/nav-block-label
branch
from
75798ac to
f83dfaf
Compare
tellthemachines
force-pushed
the
fix/nav-block-label
branch
from
f83dfaf to
f83f768
Compare
jasmussen
added a commit
that referenced
this pull request
Mar 2, 2021
The custom select control does not appear used at all in the placeholder anymore. See also #23297.
jasmussen
added a commit
that referenced
this pull request
Mar 8, 2021
The custom select control does not appear used at all in the placeholder anymore. See also #23297.
jasmussen
added a commit
that referenced
this pull request
Mar 10, 2021
The custom select control does not appear used at all in the placeholder anymore. See also #23297.
jasmussen
added a commit
that referenced
this pull request
Mar 10, 2021
* Retire theme.scss. * Group reset styles. * Retire dead CSS. The custom select control does not appear used at all in the placeholder anymore. See also #23297. * Whitespace and color tweaks. * Show submenus above the sibling inserter. * Address feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22999 and #22987.
Replaces unsemantic block description with select control label, removes placeholder text inside select control and updates the copy according to advice on #22987.
Due to use of the label that is part of the select control component, the control layout had to be slightly changed.
Previous:
Updated to:
How has this been tested?
Tested in browser and with VoiceOver + Safari.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: