Cover Image: Extract title as children array (fix "modified externally") #2341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1929
This pull request seeks to resolve an issue where the Cover Image block can trigger a "modified externally" warning after adding inline formatting to the title text. This is caused by an incompatibility between how the attribute is sourced, and how it is assigned / edited. Specifically:
The value of
Editable
should always be an attribute which is sourced aschildren
. We should consider adding better logging / messaging around the expected type of itsvalue
(i.e. warn if passed as string).Testing instructions:
Verify with the following flow you do not see a "modified externally" warning: