Update layout and text of 'Text two columns' pattern #23853
Conversation
enriquesanchez
added
the
[Feature] Patterns
enriquesanchez
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
|
When exactly would someone actually create a layout like this? The proper way to handle multi-column text would be the CSS What would make more sense is adding a new kind of "Content Columns" (no idea what to call it) block that lets you define a number of columns and a wrapping height, which would make use of the aforementioned CSS property. Also, why even include a font size or line height style on the Heading block? I think that should be removed. |
I agree that a block like that is preferable, but in general I think this pattern serves the purpose of letting people know they can put text into multiple columns today (even with the faults you mention). The larger font size is subtle, but from a purely visual perspective I kind of like it:
Making the headline a little bigger increases the visual contrast between the paragraphs and the title. And the 1.5 line height is a better fit for this slightly larger text. I tried this in a couple other themes and these settings translate to a nice ratio too. From a systematic perspective I'm a little less into it — if the user inserts this alongside other I do have one additional note though. In my testing, Gutenberg's default styles create two em dashes in a row in that left column at the default content width on desktop:
This is not a huge deal obviously, but since we're choosing this text, it would be great to avoid that. Same goes for the particularly short line caused by the word "involuntarily" not breaking over in the right column. (If we keep em dashes, I should also note that stylistically, I'm also big proponent of the AP style recommendation of adding spaces before and after em dashes). |
|
Thanks for the feedback. I've removed the custom font size from the heading and edited the text for visual balance:
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Moves the heading out of the text block and places it above. Also edited the text to have balanced columns.
Before:
After: