Persist tooltips on hover #23959
Merged
Persist tooltips on hover #23959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Focus] Accessibility (a11y)
ntsekouras
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
youknowriad
reviewed
Jul 15, 2020
| @@ -17,9 +17,6 @@ | |||
| font-size: 12px; | |||
| box-shadow: none; | |||
|
|
|||
| // This prevents quickly hovering the tooltip from blocking hovering something else. | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
@jasmussen do you remember why we add this? (It was added on the original G2 branch).
There was a problem hiding this comment.
From the comment, it looks like it was added to make the tooltip "invisible" to a cursor so a user wouldn't accidentally click it when trying to click something else in the UI or on the canvas.
There was a problem hiding this comment.
I think Michael is right, yes. If you hover a button and see a tooltip, that might cover a button immediately above it, and if you quickly click there to click that button, you should be able to.
|
Tested locally, and it looks like it resolves the issue! Tooltips are able to persist. It looks like it was added during the G2 design refresh. I feel like there's a reason for this, but I'm lacking the context. Dropdowns, Top Toolbar mode, and typical mouse-based navigation still work. I'm comfortable with this fix @ntsekouras ! 🚀 |
|
Size Change: -20 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jul 15, 2020
|
Thanks for fixing this so quickly. This should be included in WP 5.5 though, what is the best way to make sure that happens? @youknowriad |
|
yes, It has the "backport to Core" label, it means it will be backported before the next WordPress 5.5 beta. |
6 tasks
ellatrix
pushed a commit
that referenced
this pull request
Jul 20, 2020
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #23958
Checklist: