Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Disable tools while code editor mode is enable #24923

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Enhancement: Disable tools while code editor mode is enable #24923

merged 4 commits into from
Aug 31, 2020

Conversation

kishanjasani
Copy link
Contributor

@kishanjasani kishanjasani commented Aug 31, 2020 •
edited by youknowriad
Loading

closes #24917

Description

I have one property to check whether the code editor mode is enabled or not.

How has this been tested?

  • I have tested changes with Wordpress5.5
  • The code is only for that particular component won't affect other components.

Screenshots

screenshot-gutenberg local-2020 08 31-12_32_34

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@youknowriad youknowriad added the [Type] Enhancement A suggestion for improvement. label Aug 31, 2020
youknowriad
youknowriad approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ntsekouras ntsekouras merged commit ab0d01b into WordPress:master Aug 31, 2020
@github-actions github-actions bot added this to the Gutenberg 8.9 milestone Aug 31, 2020
@miminari miminari mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 8.9
Development

Successfully merging this pull request may close these issues.

Edit header toolbar Tools button
3 participants
@kishanjasani @youknowriad @ntsekouras