Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Warning 2 : Fix Console error when trying to open the aspect-ratio tool for images #24996

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Resolve Warning 2 : Fix Console error when trying to open the aspect-ratio tool for images #24996

merged 1 commit into from
Sep 17, 2020

Conversation

kishanjasani
Copy link
Contributor

@kishanjasani kishanjasani commented Sep 2, 2020 •
edited
Loading

Fixed Issue: #24971

Description

I have changed the one invalid attribute of the component. Which was creating a console error.
Resolved 2nd warning from the issue.

How has this been tested?

I have tested it by defining define( 'SCRIPT_DEBUG', true ); in my wp-config.php and tested.

Types of changes

Validate invalid property with the valid one.
It a non-breaking change to component.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

ajlende
ajlende approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 👍

@ajlende ajlende merged commit 0620099 into WordPress:master Sep 17, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 17, 2020
@youknowriad youknowriad mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajlende ajlende ajlende approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kishanjasani @ajlende